feat: Introduced validation attribute for DateOnly to have better control over error messages

Author: alex-clayton-1

src/ServiceLayer.API/Functions/BSSelectFunctions.cs

@@ -46,7 +46,7 @@ public async Task<IActionResult> IngressEpisode([HttpTrigger(AuthorizationLevel.
                 PathwayTypeName = "Breast Screening Routine",
                 ScreeningName = "Breast Screening",
                 NhsNumber = bssEpisodeEvent.NhsNumber!,
-                DOB = (DateOnly)bssEpisodeEvent.DateOfBirth!,
+                DOB = DateOnly.Parse(bssEpisodeEvent.DateOfBirth!),
                 Name = $"{bssEpisodeEvent.FirstGivenName} {bssEpisodeEvent.FamilyName}",
             };
 

src/ServiceLayer.API/Models/BSSelectEpisode.cs

@@ -1,5 +1,6 @@
 using System.ComponentModel.DataAnnotations;
 using System.Text.Json.Serialization;
+using ServiceLayer.API.Shared;
 
 namespace ServiceLayer.API.Models;
 
@@ -16,7 +17,8 @@ public class BSSelectEpisode
 
     [JsonPropertyName("date_of_birth")]
     [Required(ErrorMessage = "date_of_birth is required")]
-    public DateOnly? DateOfBirth { get; set; }
+    [ValidDateOnly(ErrorMessage = "date_of_birth is invalid")]
+    public string? DateOfBirth { get; set; }
 
     [JsonPropertyName("first_given_name")]
     [Required(ErrorMessage = "first_given_name is required")]

src/ServiceLayer.API/Shared/ValidDateOnlyAttribute.cs

@@ -0,0 +1,16 @@
+using System.ComponentModel.DataAnnotations;
+
+namespace ServiceLayer.API.Shared;
+
+public class ValidDateOnlyAttribute : ValidationAttribute
+{
+    public override bool IsValid(object? value)
+    {
+        if (value is string s && DateOnly.TryParse(s, out _))
+        {
+            return true;
+        }
+
+        return false;
+    }
+}

tests/ServiceLayer.API.Tests/Functions/BSSelectFunctionsTests.cs

@@ -207,6 +207,8 @@ public async Task CreateEpisodeEvent_ShouldReturnBadRequest_WhenDateOfBirthIsMis
 
     [Theory]
     [InlineData(null)]
+    [InlineData("")]
+    [InlineData(" ")]
     public async Task CreateEpisodeEvent_ShouldReturnBadRequest_WhenDateOfBirthIsEmptyValue(string? dateOfBirth)
     {
         // Arrange
@@ -229,6 +231,31 @@ public async Task CreateEpisodeEvent_ShouldReturnBadRequest_WhenDateOfBirthIsEmp
         _mockEventGridPublisherClient.Verify(x => x.SendEventAsync(It.IsAny<CloudEvent>(), It.IsAny<CancellationToken>()), Times.Never());
     }
 
+    [Theory]
+    [InlineData("ABC")]
+    [InlineData("123")]
+    public async Task CreateEpisodeEvent_ShouldReturnBadRequest_WhenDateOfBirthIsInvalidValue(string? dateOfBirth)
+    {
+        // Arrange
+        var episode = new
+        {
+            episode_id = "123",
+            nhs_number = "9990000000",
+            date_of_birth = dateOfBirth,
+            first_given_name = "Test",
+            family_name = "User",
+        };
+        var request = _setupRequest.CreateMockHttpRequest(episode);
+
+        // Act
+        var response = await _functions.IngressEpisode(request);
+
+        // Assert
+        var result = Assert.IsType<BadRequestObjectResult>(response);
+        Assert.Equal("date_of_birth is invalid", result.Value);
+        _mockEventGridPublisherClient.Verify(x => x.SendEventAsync(It.IsAny<CloudEvent>(), It.IsAny<CancellationToken>()), Times.Never());
+    }
+
     [Fact]
     public async Task CreateEpisodeEvent_ShouldReturnBadRequest_WhenFirstGivenNameIsMissing()
     {