Remove redundant ErrorMessage property

Author: ianfnelson

src/ServiceLayer.Mesh/FileTypes/NbssAppointmentEvents/FileParsingException.cs

@@ -3,19 +3,17 @@ namespace ServiceLayer.Mesh.FileTypes.NbssAppointmentEvents;
 public class FileParsingException : Exception
 {
     public string Code { get; }
-    public string ErrorMessage { get; }
 
-    public FileParsingException(string code, string errorMessage)
-        : base(errorMessage)
+    public FileParsingException(string code, string message)
+        : base(message)
     {
         Code = code;
-        ErrorMessage = errorMessage;
     }
 
-    public FileParsingException(string code, string errorMessage, Exception innerException)
-        : base(errorMessage, innerException)
+    public FileParsingException(string code, string message, Exception innerException)
+        : base(message, innerException)
     {
         Code = code;
-        ErrorMessage = errorMessage;
     }
 }
+

src/ServiceLayer.Mesh/FileTypes/NbssAppointmentEvents/FileTransformer.cs

@@ -40,14 +40,14 @@ public override async Task<IList<ValidationError>> TransformFileAsync(Stream str
     private List<ValidationError> HandleFileParsingException(FileParsingException ex)
     {
         logger.LogError("File parsing failed with validation error. Code: {ErrorCode}, Message: {ErrorMessage}",
-            ex.Code, ex.ErrorMessage);
+            ex.Code, ex.Message);
 
         return
         [
             new ValidationError
             {
                 Code = ex.Code,
-                Error = ex.ErrorMessage,
+                Error = ex.Message,
                 Scope = ValidationErrorScope.File
             }
         ];

tests/ServiceLayer.Mesh.Tests/FileTypes/NbssAppointmentEvents/FileParserTests.cs

@@ -22,7 +22,7 @@ public FileParserTests()
 
     private FileStream GetTestFileStream(string fileName)
     {
-        string filePath = Path.Combine(_testDataPath, fileName);
+        var filePath = Path.Combine(_testDataPath, fileName);
         return File.OpenRead(filePath);
     }
 
@@ -154,7 +154,7 @@ public void Parse_MissingFieldsRecord_ThrowsFileParsingException()
         var exception = Assert.Throws<FileParsingException>(() => _fileParser.Parse(fileStream));
 
         Assert.Equal(ErrorCodes.MissingFieldHeadings, exception.Code);
-        Assert.Equal("Field headings are missing", exception.ErrorMessage);
+        Assert.Equal("Field headings are missing", exception.Message);
     }
 
     [Fact]
@@ -167,7 +167,7 @@ public void Parse_UnknownRecordType_ThrowsFileParsingException()
         var exception = Assert.Throws<FileParsingException>(() => _fileParser.Parse(fileStream));
 
         Assert.Equal(ErrorCodes.UnknownRecordTypeIdentifier, exception.Code);
-        Assert.Equal("Unknown Record Identifier UNKNOWN_TYPE", exception.ErrorMessage);
+        Assert.Equal("Unknown Record Identifier UNKNOWN_TYPE", exception.Message);
     }
 
     [Fact]
@@ -333,7 +333,7 @@ public void Parse_DataRecordBeforeFields_ThrowsFileParsingExceptionWithCorrectCo
         var exception = Assert.Throws<FileParsingException>(() => _fileParser.Parse(stream));
 
         Assert.Equal(ErrorCodes.MissingFieldHeadings, exception.Code);
-        Assert.Equal("Field headings are missing", exception.ErrorMessage);
+        Assert.Equal("Field headings are missing", exception.Message);
     }
 
     [Fact]
@@ -346,7 +346,7 @@ public void Parse_UnknownRecordTypeWithNullIdentifier_ThrowsFileParsingException
         var exception = Assert.Throws<FileParsingException>(() => _fileParser.Parse(stream));
 
         Assert.Equal(ErrorCodes.UnknownRecordTypeIdentifier, exception.Code);
-        Assert.Equal("Unknown Record Identifier ", exception.ErrorMessage);
+        Assert.Equal("Unknown Record Identifier ", exception.Message);
     }
 
     [Fact]
@@ -359,7 +359,7 @@ public void Parse_UnknownRecordTypeWithEmptyString_ThrowsFileParsingExceptionWit
         var exception = Assert.Throws<FileParsingException>(() => _fileParser.Parse(stream));
 
         Assert.Equal(ErrorCodes.UnknownRecordTypeIdentifier, exception.Code);
-        Assert.Equal("Unknown Record Identifier ", exception.ErrorMessage);
+        Assert.Equal("Unknown Record Identifier ", exception.Message);
     }
 
     [Fact]
@@ -373,7 +373,7 @@ public void Parse_FileParsingExceptionWithInnerException_PreservesInnerException
 
         // Assert
         Assert.Equal("TEST001", exception.Code);
-        Assert.Equal("Test error", exception.ErrorMessage);
+        Assert.Equal("Test error", exception.Message);
         Assert.Equal(innerException, exception.InnerException);
         Assert.Equal("Test error", exception.Message);
     }