extract function configuration

Author: ianfnelson

src/ServiceLayer.Mesh/Functions/FileExtractFunction.cs

@@ -2,6 +2,7 @@
 using Microsoft.EntityFrameworkCore;
 using Microsoft.Extensions.Logging;
 using NHS.MESH.Client.Contracts.Services;
+using ServiceLayer.Mesh.Configuration;
 using ServiceLayer.Mesh.Data;
 using ServiceLayer.Mesh.Messaging;
 using ServiceLayer.Mesh.Models;
@@ -10,7 +11,8 @@
 namespace ServiceLayer.Mesh.Functions;
 
 public class FileExtractFunction(
-    ILogger logger,
+    ILogger<FileExtractFunction> logger,
+    IFileExtractFunctionConfiguration configuration,
     IMeshInboxService meshInboxService,
     ServiceLayerDbContext serviceLayerDbContext,
     IFileTransformQueueClient fileTransformQueueClient,
@@ -53,10 +55,7 @@ public async Task Run([QueueTrigger("file-extract")] FileExtractQueueMessage mes
 
         try
         {
-            var mailboxId = Environment.GetEnvironmentVariable("NBSSMailBoxId")
-                ?? throw new InvalidOperationException($"Environment variable 'NBSSMailBoxId' is not set or is empty.");
-
-            var meshResponse = await meshInboxService.GetMessageByIdAsync(mailboxId, file.FileId);
+            var meshResponse = await meshInboxService.GetMessageByIdAsync(configuration.NbssMeshMailboxId, file.FileId);
             if (!meshResponse.IsSuccessful)
             {
                 // TODO - what to do if unsuccessful?
@@ -65,7 +64,7 @@ public async Task Run([QueueTrigger("file-extract")] FileExtractQueueMessage mes
 
             var blobPath = await meshFileBlobStore.UploadAsync(file, meshResponse.Response.FileAttachment.Content);
 
-            var meshAcknowledgementResponse = await meshInboxService.AcknowledgeMessageByIdAsync(mailboxId, message.FileId);
+            var meshAcknowledgementResponse = await meshInboxService.AcknowledgeMessageByIdAsync(configuration.NbssMeshMailboxId, message.FileId);
             if (!meshResponse.IsSuccessful)
             {
                 // TODO - what to do if unsuccessful?

tests/ServiceLayer.Mesh.Tests/Functions/FileExtractFunctionTests.cs

@@ -3,6 +3,7 @@
 using Moq;
 using NHS.MESH.Client.Contracts.Services;
 using NHS.MESH.Client.Models;
+using ServiceLayer.Mesh.Configuration;
 using ServiceLayer.Mesh.Data;
 using ServiceLayer.Mesh.Functions;
 using ServiceLayer.Mesh.Messaging;
@@ -17,6 +18,7 @@ public class FileExtractFunctionTests
     private readonly Mock<IMeshInboxService> _meshInboxServiceMock;
     private readonly Mock<IFileTransformQueueClient> _fileTransformQueueClientMock;
     private readonly Mock<IFileExtractQueueClient> _fileExtractQueueClientMock;
+    private readonly Mock<IFileExtractFunctionConfiguration> _configurationMock;
     private readonly Mock<IMeshFilesBlobStore> _blobStoreMock;
     private readonly ServiceLayerDbContext _dbContext;
     private readonly FileExtractFunction _function;
@@ -37,10 +39,12 @@ public FileExtractFunctionTests()
 
         _dbContext = new ServiceLayerDbContext(options);
 
-        Environment.SetEnvironmentVariable("NBSSMailBoxId", "test-mailbox");
+        var functionConfiguration = new Mock<IFileExtractFunctionConfiguration>();
+        functionConfiguration.Setup(c => c.NbssMeshMailboxId).Returns("test-mailbox");
 
         _function = new FileExtractFunction(
             _loggerMock.Object,
+            functionConfiguration.Object,
             _meshInboxServiceMock.Object,
             _dbContext,
             _fileTransformQueueClientMock.Object,