remove update_user_restricted_app_attr

Author: kevinmason-nhs

tests/integration/test_headers.py

@@ -40,48 +40,44 @@ async def test_headers_on_echo_target(
         update_user_restricted_app_attr,
         app_restricted_ods_code,
     ):
-        with update_user_restricted_app_attr(
-            "apim-app-flow-vars",
-            '{"ers": {"allowListodsCode": [ ' + app_restricted_ods_code + " ]}}",
-        ):
-            access_code = await authenticate_user(user)
+        access_code = await authenticate_user(user)
 
-            client_request_headers = {
-                _HEADER_ECHO: "",  # enable echo target
-                _HEADER_AUTHORIZATION: "Bearer " + access_code,
-                _HEADER_REQUEST_ID: "DUMMY-VALUE",
-                RenamedHeader.REFERRAL_ID.original: _EXPECTED_REFERRAL_ID,
-                RenamedHeader.CORRELATION_ID.original: _EXPECTED_CORRELATION_ID,
-                RenamedHeader.BUSINESS_FUNCTION.original: user.business_function,
-                RenamedHeader.ODS_CODE.original: user.org_code,
-                RenamedHeader.FILENAME.original: _EXPECTED_FILENAME,
-                RenamedHeader.COMM_RULE_ORG.original: _EXPECTED_COMM_RULE_ORG,
-                RenamedHeader.OBO_USER_ID.original: _EXPECTED_OBO_USER_ID,
-            }
+        client_request_headers = {
+            _HEADER_ECHO: "",  # enable echo target
+            _HEADER_AUTHORIZATION: "Bearer " + access_code,
+            _HEADER_REQUEST_ID: "DUMMY-VALUE",
+            RenamedHeader.REFERRAL_ID.original: _EXPECTED_REFERRAL_ID,
+            RenamedHeader.CORRELATION_ID.original: _EXPECTED_CORRELATION_ID,
+            RenamedHeader.BUSINESS_FUNCTION.original: user.business_function,
+            RenamedHeader.ODS_CODE.original: user.org_code,
+            RenamedHeader.FILENAME.original: _EXPECTED_FILENAME,
+            RenamedHeader.COMM_RULE_ORG.original: _EXPECTED_COMM_RULE_ORG,
+            RenamedHeader.OBO_USER_ID.original: _EXPECTED_OBO_USER_ID,
+        }
 
-            # Make the API call
-            response = requests.get(service_url, headers=client_request_headers)
+        # Make the API call
+        response = requests.get(service_url, headers=client_request_headers)
 
-            expected_aal = (
-                "3"
-                if user.authentication_assurance_level == UserAuthenticationLevel.AAL3
-                else "2"
-            )
-            expected_amr = (
-                "[N3_SMARTCARD]"
-                if user.authentication_assurance_level == UserAuthenticationLevel.AAL3
-                else "[TOTP]"
-            )
+        expected_aal = (
+            "3"
+            if user.authentication_assurance_level == UserAuthenticationLevel.AAL3
+            else "2"
+        )
+        expected_amr = (
+            "[N3_SMARTCARD]"
+            if user.authentication_assurance_level == UserAuthenticationLevel.AAL3
+            else "[TOTP]"
+        )
 
-            self.assert_ok_echo_response(
-                response,
-                service_url,
-                user,
-                asid,
-                _EXPECTED_FILENAME,
-                expected_aal,
-                expected_amr,
-            )
+        self.assert_ok_echo_response(
+            response,
+            service_url,
+            user,
+            asid,
+            _EXPECTED_FILENAME,
+            expected_aal,
+            expected_amr,
+        )
 
     @pytest.mark.asyncio
     @pytest.mark.parametrize(