fixes proxy and adds success cases

Author: kevinmason-nhs

proxies/live/apiproxy/policies/AssignMessage.SetOperationOutcomeServiceError.xml

@@ -1,4 +1,4 @@
-<AssignMessage enabled="true" name="AssignMessage.SetOperationOutcomeODSHeaderMissingR4">
+<AssignMessage enabled="true" name="AssignMessage.SetOperationOutcomeServiceError">
     <AssignVariable>
         <Name>status_code</Name>
         <Value>500</Value>

tests/integration/test_user_restricted.py

@@ -29,6 +29,50 @@
 
 @pytest.mark.integration_test
 class TestUserRestricted:
+
+    @pytest.mark.asyncio
+    @pytest.mark.parametrize(
+        "endpoint_url, is_fhir_4",
+        [("", False), ("/FHIR/R4/", True), ("/FHIR/STU3/", False)],
+    )
+    async def test_user_restricted_valid_ods_code(
+        self,
+        authenticate_user,
+        endpoint_url,
+        is_fhir_4,
+        service_url,
+        update_user_restricted_product,
+    ):
+        access_code = await authenticate_user(
+            referring_clinician, [referring_clinician.org_code]
+        )
+
+        client_request_headers = {
+            _HEADER_ECHO: "",  # enable echo target
+            _HEADER_AUTHORIZATION: "Bearer " + access_code,
+            _HEADER_REQUEST_ID: "DUMMY-VALUE",
+            RenamedHeader.REFERRAL_ID.original: _EXPECTED_REFERRAL_ID,
+            RenamedHeader.CORRELATION_ID.original: _EXPECTED_CORRELATION_ID,
+            RenamedHeader.BUSINESS_FUNCTION.original: referring_clinician.business_function,
+            RenamedHeader.ODS_CODE.original: referring_clinician.org_code,
+            RenamedHeader.FILENAME.original: _EXPECTED_FILENAME,
+            RenamedHeader.COMM_RULE_ORG.original: _EXPECTED_COMM_RULE_ORG,
+            RenamedHeader.OBO_USER_ID.original: _EXPECTED_OBO_USER_ID,
+        }
+
+        # Make the API call
+
+        # Make request with user with ODS code not in allow list (e.g. R69)
+        response = requests.get(
+            f"{service_url}{endpoint_url}", headers=client_request_headers
+        )
+
+        # Verify the status
+        # Verify 403 response with appropriate error message
+        assert (
+            response.status_code == 200
+        ), "Expected a 200 when accessing the api but got " + str(response.status_code)
+
     @pytest.mark.asyncio
     @pytest.mark.parametrize(
         "endpoint_url, is_fhir_4",