Chore: [AEA-5061] - Create test for redirection logic. Minor refactoring around that. (#266)

## Summary

- Routine Change

### Details

When the user does not have a selected role, the only page they should
be able to go to is the select your role page, and the logout page.

Author: wildjames

features/cpts_ui/change_role.feature

@@ -9,6 +9,7 @@ Feature: Users are able to change their roles, if they have multiple roles with
   @multiple_access
   Scenario: User can change their role
     Given I am logged in as a user with multiple access roles
+    And I have selected a role
     And I am on the change your role page
     When I click a change role role card
     Then I am on the 'your selected role' page
@@ -17,6 +18,7 @@ Feature: Users are able to change their roles, if they have multiple roles with
   @multiple_access
   Scenario: User can see roles with access cards
     Given I am logged in as a user with multiple access roles
+    And I have selected a role
     And I am on the change your role page
     Then I see the change role roles with access cards
     And I can see multiple change role roles with access cards
@@ -29,13 +31,15 @@ Feature: Users are able to change their roles, if they have multiple roles with
   @multiple_access
   Scenario: Change role roles without access table body is not visible by default
     Given I am logged in as a user with multiple access roles
+    And I have selected a role
     And I am on the change your role page
     Then the change role roles without access table body is not visible
 
   @allure.tms:https://nhsd-jira.digital.nhs.uk/browse/AEA-4653
   @multiple_access
   Scenario: User can expand the change role 'Roles without access' to see table contents
     Given I am logged in as a user with multiple access roles
+    And I have selected a role
     And I am on the change your role page
     When I click on the change role summary expander
     Then I see the change role roles without access table
@@ -44,6 +48,7 @@ Feature: Users are able to change their roles, if they have multiple roles with
   @multiple_access
   Scenario: User can collapse the change role 'Roles without access' to hide table contents
     Given I am logged in as a user with multiple access roles
+    And I have selected a role
     And I am on the change your role page
     And the summary table body is displayed
     When I click on the change role summary expander
@@ -59,6 +64,7 @@ Feature: Users are able to change their roles, if they have multiple roles with
 
   Scenario: user can change their role, and see a confirmation page
     Given I am logged in as a user with multiple access roles
+    And I have selected a role
     And I am on the change your role page
     When I click a change role role card
     Then I see the 'your selected role' page
@@ -71,6 +77,7 @@ Feature: Users are able to change their roles, if they have multiple roles with
   @allure.tms:https://nhsd-jira.digital.nhs.uk/browse/AEA-4974
   Scenario: User can change their role and see the correct message on the change role page
     Given I am logged in as a user with multiple access roles
+    And I have selected a role
     And I have confirmed a role
     And I am on the change your role page
     And I click a change role role card

features/cpts_ui/header.feature

@@ -37,39 +37,36 @@ Feature: Header
     Then I see the "Logout" link
 
   Scenario: Logout link is not shown if user is not logged in
-    When I go to the homepage
+    When I go to the home page
     Then I do not see the "Logout" link
 
   ############################################################################
   # SELECT YOUR ROLE
   ############################################################################
-  Scenario: Select Your Role link is shown on the homepage, if we dont select a role
-    Given I am logged in as a user with multiple access roles
-    When I go to the homepage
-    Then I see the "Select Your Role" link
-
   Scenario: Select Your Role link is not shown if I go to the select your role page
     Given I am logged in as a user with multiple access roles
-    When I go to the homepage
-    And I click the "Select Your Role" link
+    When I go to the select your role page
     Then I do not see the "Select Your Role" link
 
   Scenario: Select Your Role link is not shown if I already have a selected role
     Given I am logged in as a user with a pre selected role
-    When I go to the homepage
+    When I go to the home page
     Then I do not see the "Select Your Role" link
 
   ############################################################################
   # CHANGE ROLE
   ############################################################################
   Scenario: Change Role link is shown if the user has a selected role
     Given I am logged in as a user with multiple access roles
-    When I go to the homepage
+    And I have selected a role
+    And I have confirmed a role
+    When I go to the home page
     Then I see the "Change Role" link
 
   Scenario: Change Role link is not shown if the user has no selected role
     Given I am logged in as a user with multiple access roles
-    When I go to the homepage
+    And I have selected a role
+    When I go to the home page
     Then I do not see the "Change Role" link
 
   # FIXME: Address this when the SPA is fixed!
@@ -78,11 +75,12 @@ Feature: Header
   # @fixme
   # Scenario: Change Role link is not shown if I go to the select your role page
   #   Given I am logged in
-  #   When I have a selected role
+  #   When I have selected a role
   #   And I go to the select your role page
   #   Then I do not see the "Change Role" link
 
   Scenario: Change Role link is not shown if I am on the change role page
     Given I am logged in as a user with multiple access roles
+    And I have selected a role
     When I go to change my role
     Then I do not see the "Change Role" link

features/cpts_ui/home.feature

@@ -6,7 +6,7 @@ Feature: I can visit the Clinical Prescription Tracker Service Website
   @allure.tms:https://nhsd-jira.digital.nhs.uk/browse/AEA-4515
   @allure.tms:https://nhsd-jira.digital.nhs.uk/browse/AEA-4513
   Scenario: user can navigate to the Clinical Prescription Tracker Service Website homepage
-    When I go to the homepage
+    When I go to the home page
     Then I am on the homepage
     And I can see the header
     And I can see the footer

features/cpts_ui/notfound.feature

@@ -8,6 +8,7 @@ Feature: The site has a 404 not found page
 
     Scenario: The user sees a "Page not found" error page when they navigate to an unknown page while logged in
         Given I am logged in as a user with multiple access roles
+        And I have selected a role
         When I navigate to a non-existent page
         Then I am on the logged in Page Not Found page
 

features/cpts_ui/select_your_role.feature

@@ -12,6 +12,13 @@ Feature: Role selection page renders roles properly when logged in
     And I can see the summary container
     And I cannot see the summary table body
 
+  @allure.tms:https://nhsd-jira.digital.nhs.uk/browse/AEA-5061
+  Scenario: I am redirected to the select your role page if I have no role selected
+    When I log in as a user with multiple access roles
+    And the login has finished
+    And I go to the search for a prescription page
+    Then I can see the summary container
+
   @allure.tms:https://nhsd-jira.digital.nhs.uk/browse/AEA-4653
   Scenario: I can show the available role information
     Given I am logged in as a user with multiple access roles

features/cpts_ui/your_selected_role.feature

@@ -4,6 +4,7 @@ Feature: When the user selects a role, they see a confirmation page
 
   Background:
     Given I am logged in as a user with multiple access roles
+    And I have selected a role
 
   Scenario: user is able to select a role, and see a confirmation page
     When I click a change role role card

features/steps/cpts_ui/home_steps.py

@@ -6,14 +6,24 @@
 from pages.footer import Footer
 
 
-@when("I go to the homepage")
-def goto_page(context):
-    context.page.goto(context.cpts_ui_base_url + "site/")
+@when("I go to the {page} page")
+def goto_page(context, page):
+    target = ""
+
+    if page == "home":
+        target = ""
+    elif page == "search for a prescription":
+        target = "searchforaprescription"
+    elif page == "select your role":
+        target = "selectyourrole"
+
+    url = f"{context.cpts_ui_base_url}site/{target}"
+    context.page.goto(url)
 
 
 @given("I am on the homepage")
 def i_am_on_the_home_page(context):
-    goto_page(context)
+    goto_page(context, "home")
     header = Header(context.page)
     header.page.is_visible(header.header)
 

features/steps/cpts_ui/login_steps.py

@@ -32,7 +32,6 @@ def login_single_role(context):
 @given("I am logged in as a user with multiple access roles")
 def login_multiple_access_roles(context):
     context.execute_steps("when I log in as a user with multiple access roles")
-    context.execute_steps("When I select a role")
 
 
 @given("I am logged in as a user with only roles that do not have access")
@@ -65,6 +64,8 @@ def login_with_multiple_access_roles(context):
     context.page.get_by_label("Username").fill(MOCK_CIS2_LOGIN_ID_MULTIPLE_ACCESS_ROLES)
     context.page.get_by_role("button", name="Sign In").click()
 
+    context.execute_steps("When the login has finished")
+
 
 @when("I log in as a user with no roles")
 def login_with_no_roles(context):
@@ -74,6 +75,8 @@ def login_with_no_roles(context):
     context.page.get_by_label("Username").fill(MOCK_CIS2_LOGIN_ID_NO_ROLES)
     context.page.get_by_role("button", name="Sign In").click()
 
+    context.execute_steps("When the login has finished")
+
 
 @when("I log in as a user with only roles that do not have access")
 def login_with_without_access(context):
@@ -83,6 +86,8 @@ def login_with_without_access(context):
     context.page.get_by_label("Username").fill(MOCK_CIS2_LOGIN_ID_NO_ACCESS_ROLE)
     context.page.get_by_role("button", name="Sign In").click()
 
+    context.execute_steps("When the login has finished")
+
 
 @when("I log in with a single access role and multiple without access")
 def login_with_single_role_with_access_multiple_without(context):
@@ -94,6 +99,8 @@ def login_with_single_role_with_access_multiple_without(context):
     )
     context.page.get_by_role("button", name="Sign In").click()
 
+    context.execute_steps("When the login has finished")
+
 
 @when("I log in as a user with a pre selected role")
 def login_with_pre_role_selected(context):
@@ -104,6 +111,8 @@ def login_with_pre_role_selected(context):
     )
     context.page.get_by_role("button", name="Sign In").click()
 
+    context.execute_steps("When the login has finished")
+
 
 @when("I log in as a user with a single access role")
 def login_with_single_role(context):
@@ -113,6 +122,21 @@ def login_with_single_role(context):
     context.page.get_by_label("Username").fill(MOCK_CIS2_LOGIN_ID_SINGLE_ACCESS_ROLE)
     context.page.get_by_role("button", name="Sign In").click()
 
+    context.execute_steps("When the login has finished")
+
+
+@when("The login has finished")
+def the_login_is_finished(context):
+    def logged_in_urls(url):
+        valid_urls = [
+            f"{context.cpts_ui_base_url}site/selectyourrole",
+            f"{context.cpts_ui_base_url}site/selectyourrole/",
+        ]
+        return url in valid_urls
+
+    context.page.wait_for_url(logged_in_urls)
+    context.execute_steps("then I am logged in")
+
 
 ###############################################################################
 # THEN STEPS