Skip to content

Commit 5c75a5d

Browse files
authored
Fix: [AEA-0000] - Use proper given clause in change role tests (#274)
## Summary - Routine Change ### Details I had a look at the change role tests, and I think this clause was incorrect. We want to CONFIRM a role, not just SELECT one. I wonder if this helps the flakiness?
1 parent 748af12 commit 5c75a5d

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

features/cpts_ui/change_role.feature

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ Feature: Users are able to change their roles, if they have multiple roles with
99
@multiple_access
1010
Scenario: User can change their role
1111
Given I am logged in as a user with multiple access roles
12-
And I have selected a role
12+
And I have confirmed a role
1313
And I am on the change your role page
1414
When I click a change role role card
1515
Then I am on the 'your selected role' page
@@ -18,7 +18,7 @@ Feature: Users are able to change their roles, if they have multiple roles with
1818
@multiple_access
1919
Scenario: User can see roles with access cards
2020
Given I am logged in as a user with multiple access roles
21-
And I have selected a role
21+
And I have confirmed a role
2222
And I am on the change your role page
2323
Then I see the change role roles with access cards
2424
And I can see multiple change role roles with access cards
@@ -31,15 +31,15 @@ Feature: Users are able to change their roles, if they have multiple roles with
3131
@multiple_access
3232
Scenario: Change role roles without access table body is not visible by default
3333
Given I am logged in as a user with multiple access roles
34-
And I have selected a role
34+
And I have confirmed a role
3535
And I am on the change your role page
3636
Then the change role roles without access table body is not visible
3737

3838
@allure.tms:https://nhsd-jira.digital.nhs.uk/browse/AEA-4653
3939
@multiple_access
4040
Scenario: User can expand the change role 'Roles without access' to see table contents
4141
Given I am logged in as a user with multiple access roles
42-
And I have selected a role
42+
And I have confirmed a role
4343
And I am on the change your role page
4444
When I click on the change role summary expander
4545
Then I see the change role roles without access table
@@ -48,7 +48,7 @@ Feature: Users are able to change their roles, if they have multiple roles with
4848
@multiple_access
4949
Scenario: User can collapse the change role 'Roles without access' to hide table contents
5050
Given I am logged in as a user with multiple access roles
51-
And I have selected a role
51+
And I have confirmed a role
5252
And I am on the change your role page
5353
And the summary table body is displayed
5454
When I click on the change role summary expander
@@ -64,7 +64,7 @@ Feature: Users are able to change their roles, if they have multiple roles with
6464

6565
Scenario: user can change their role, and see a confirmation page
6666
Given I am logged in as a user with multiple access roles
67-
And I have selected a role
67+
And I have confirmed a role
6868
And I am on the change your role page
6969
When I click a change role role card
7070
Then I see the 'your selected role' page
@@ -77,7 +77,6 @@ Feature: Users are able to change their roles, if they have multiple roles with
7777
@allure.tms:https://nhsd-jira.digital.nhs.uk/browse/AEA-4974
7878
Scenario: User can change their role and see the correct message on the change role page
7979
Given I am logged in as a user with multiple access roles
80-
And I have selected a role
8180
And I have confirmed a role
8281
And I am on the change your role page
8382
And I click a change role role card

0 commit comments

Comments
 (0)