Move the login without access step to common steps

Author: kris-szlapa

features/cpts_ui/select_your_role.feature

@@ -38,7 +38,7 @@ Feature: Role selection page renders roles properly when logged in
         Then I can see the roles with access cards
 
     @allure.tms:https://nhsd-jira.digital.nhs.uk/browse/AEA-4651
-    Scenario: User can navigate to the your_selected_role page
+    Scenario: User can navigate to the your selected role page
         Given I am logged in
         Then I am on the select your role page
         Then I can navigate to the your selected role page by clicking a card

features/steps/cpts_ui/common_steps.py

@@ -1,7 +1,10 @@
 # pylint: disable=no-name-in-module
 from behave import given, then  # pyright: ignore [reportAttributeAccessIssue]
 
-from features.environment import MOCK_CIS2_LOGIN_ID_MULTIPLE_ACCESS_ROLES
+from features.environment import (
+    MOCK_CIS2_LOGIN_ID_MULTIPLE_ACCESS_ROLES,
+    MOCK_CIS2_LOGIN_ID_NO_ACCESS_ROLE,
+)
 
 
 @then("I am logged out")
@@ -44,6 +47,15 @@ def login(context):
     context.page.wait_for_url("**/selectyourrole.html")
 
 
+@given("I am logged in without access")
+def login_without_access(context):
+    context.page.goto(context.cpts_ui_base_url + "site/auth_demo.html")
+    context.page.get_by_role("button", name="Log in with mock CIS2").click()
+    context.page.get_by_label("Username").fill(MOCK_CIS2_LOGIN_ID_NO_ACCESS_ROLE)
+    context.page.get_by_role("button", name="Sign In").click()
+    context.page.wait_for_url("**/selectyourrole.html")
+
+
 @then("I am on the login page")
 def i_am_on_login_page(context):
     # TODO: This needs to cover the .html for the broken SPA. Will need to be removed.

features/steps/cpts_ui/select_your_role_steps.py

@@ -3,7 +3,6 @@
 from playwright.sync_api import expect
 
 from pages.select_your_role import SelectYourRole
-from features.environment import MOCK_CIS2_LOGIN_ID_NO_ACCESS_ROLE
 
 
 @when("I go to the select your role page")
@@ -19,15 +18,6 @@ def i_am_on_select_your_role_page(context):
     expect(select_your_role_page.summary).to_be_visible()
 
 
-@given("I am logged in without access")
-def login_without_access(context):
-    context.page.goto(context.cpts_ui_base_url + "site/auth_demo.html")
-    context.page.get_by_role("button", name="Log in with mock CIS2").click()
-    context.page.get_by_label("Username").fill(MOCK_CIS2_LOGIN_ID_NO_ACCESS_ROLE)
-    context.page.get_by_role("button", name="Sign In").click()
-    context.page.wait_for_url("**/selectyourrole.html")
-
-
 @then("I am on the select your role page")
 def verify_on_select_your_role_page(context):
     select_your_role_page = SelectYourRole(context.page)