Skip to content

Commit 7dceb31

Browse files
authored
Fix: [AEA-0000] - fix rsync with new download location with @download-artifact@v5 (#455)
## Summary - Routine Change ### Details - fix rsync with new download location with @download-artifact@v5 - run a basic ping regression test on pull requests - move to common pr_title_check
1 parent fe2963a commit 7dceb31

File tree

3 files changed

+46
-37
lines changed

3 files changed

+46
-37
lines changed

.github/workflows/pr_title_check.yml

Lines changed: 0 additions & 33 deletions
This file was deleted.

.github/workflows/pull_request.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,14 @@ jobs:
1212
uses: NHSDigital/eps-workflow-quality-checks/.github/workflows/[email protected]
1313
secrets:
1414
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
15-
15+
1616
pr_title_format_check:
17-
uses: ./.github/workflows/pr_title_check.yml
17+
uses: NHSDigital/eps-workflow-semantic-release/.github/workflows/pr_title_check.yml@13024fccca97e125d448ca9bc4616cfd413197fe
18+
19+
run_basic_regression_test:
20+
uses: ./.github/workflows/regression_tests.yml
21+
with:
22+
tags: "@ping"
23+
environment: INTERNAL-DEV
24+
product: EPS-FHIR
25+
id: "Pull Request Basic Regression Tests"

.github/workflows/regression_tests.yml

Lines changed: 36 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,39 @@ on:
4343
type: boolean
4444
description: "Generate a report for successful test runs"
4545
default: false
46+
workflow_call:
47+
inputs:
48+
tags:
49+
description: "Test scenario tags. If you want to specify multiple tags, you should separate them with a colon :"
50+
required: true
51+
type: string
52+
environment:
53+
description: "Environment to run tests against"
54+
type: string
55+
default: "DEV"
56+
product:
57+
description: "The product we are testing"
58+
type: string
59+
default: EPS-FHIR
60+
id:
61+
description: "Unique run identifier (Do not change this)"
62+
required: false
63+
type: string
64+
default: "Manually Triggered Run"
65+
pull_request_id:
66+
description: "The ID of the pull request. This should be in the format pr-xxxx where xxxx is the pull request id"
67+
required: false
68+
type: string
69+
default: ""
70+
github_tag:
71+
description: "The github tag to run the test pack from"
72+
required: false
73+
type: string
74+
default: "main"
75+
generate_report:
76+
type: boolean
77+
description: "Generate a report for successful test runs"
78+
default: false
4679

4780
jobs:
4881
regression_tests:
@@ -265,8 +298,8 @@ jobs:
265298
- name: Place matrix artifacts in allure results
266299
run: |
267300
mkdir -p allure-results
268-
rsync -av downloaded_artifacts/*/* allure-results/
269-
rsync -av downloaded_artifacts/*/environment.properties allure-results/
301+
rsync -av downloaded_artifacts/* allure-results/
302+
rsync -av downloaded_artifacts/environment.properties allure-results/
270303
271304
- name: Upload Artifact
272305
uses: actions/upload-artifact@v4
@@ -319,6 +352,7 @@ jobs:
319352
- name: Generate a token
320353
id: generate-token
321354
uses: actions/create-github-app-token@v2
355+
if: contains(needs.*.result, 'failure') || github.event.inputs.generate_report == 'true'
322356
with:
323357
app-id: ${{ vars.REGRESSION_TESTS_APP_ID }}
324358
private-key: ${{ secrets.REGRESSION_TESTS_PEM }}

0 commit comments

Comments
 (0)