Fix: [AEA-5516] - Fixed tracker details page items tests (#415)

## Summary

- Routine Change

### Details

Also fixed display names of medications for generated and dispensed
prescriptions.

Author: MatthewPopat-NHS

features/cpts_ui/prescription_detail.feature

@@ -38,14 +38,6 @@ Feature: Prescription Detail Page in the Clinical Prescription Tracker Service
     And The dispenser site card is visible
     And The nominated dispenser site card is visible
 
-  @allure.tms:https://nhsd-jira.digital.nhs.uk/browse/AEA-4799
-  @skip # can't make multi item prescriptions as it stands
-  Scenario: User sees both prescribed and dispensed item cards
-    Given a new prescription has been dispensed
-    When I go to the prescription details
-    Then The prescribed items card is visible
-    And The dispensed items card is visible
-
   @allure.tms:https://nhsd-jira.digital.nhs.uk/browse/AEA-4799
   Scenario: User sees EPS status tag on item card
     Given a nominated acute prescription has been created
@@ -57,24 +49,13 @@ Feature: Prescription Detail Page in the Clinical Prescription Tracker Service
     Given a nominated acute prescription has been created and released
     And the prescription has been cancelled
     When I go to the prescription details
-    Then The prescribed items card is visible
-    And The dispensed items card is not visible
-    And A prescribed item card shows a cancellation warning
-
-  @allure.tms:https://nhsd-jira.digital.nhs.uk/browse/AEA-4799
-  @skip # can't dispense a different item to the original prescription as it stands
-  Scenario: User sees only dispensed item cards, with expandable and status tag
-    Given a new prescription has been dispensed
-    When I go to the prescription details
-    Then The prescribed items card is not visible
-    And The dispensed items card is visible
-    And A dispensed item card has expandable initial prescription
+    Then An item card shows a cancellation warning
 
   @allure.tms:https://nhsd-jira.digital.nhs.uk/browse/AEA-4799
-  Scenario: Dispensed item cards do not show pharmacy status when it is missing
+  Scenario: Item cards do not show pharmacy status when it is missing
     Given a new prescription has been dispensed
     When I go to the prescription details
-    Then No pharmacy status label is shown in the dispensed item card
+    Then No pharmacy status label is shown in the item card
 
   @allure.tms:https://nhsd-jira.digital.nhs.uk/browse/AEA-4801
   Scenario: User sees message history with dispense notification dropdown

features/steps/cpts_ui/prescription_details_steps.py

@@ -70,44 +70,20 @@ def site_card_visibility_check(context, org, visibility):
         raise ValueError(f"Unrecognised visibility definition: {visibility}")
 
 
-@then("The {type} items card is {visibility}")
-def item_card_visibility(context, type, visibility):
-    header_text = "Dispensed items" if type == "dispensed" else "Prescribed items"
-    section = context.page.get_by_role("heading", name=header_text)
-
-    if visibility == "visible":
-        expect(section).to_be_visible()
-    elif visibility == "not visible":
-        expect(section).not_to_be_visible()
-    else:
-        raise ValueError(f"Invalid visibility: {visibility}")
-
-
 @then("An item card shows an EPS status tag")
 def item_card_eps_status_tag(context):
     page = PrescriptionDetailsPage(context.page)
 
     expect(page.eps_status_tag.first).to_be_visible()
 
 
-@then("A prescribed item card shows a cancellation warning")
-def prescribed_item_card_cancellation_warning(context):
+@then("An item card shows a cancellation warning")
+def item_card_cancellation_warning(context):
     warning = context.page.get_by_text("This item is pending cancellation.").first
     expect(warning).to_be_visible()
 
 
-@then("A dispensed item card has expandable initial prescription")
-def dispensed_item_has_expandable_details(context):
-    page = PrescriptionDetailsPage(context.page)
-
-    expander = page.initial_prescription_details
-    expander.click()
-
-    details_summary_list = page.initial_prescription_summary
-    expect(details_summary_list).to_be_visible()
-
-
-@then("No pharmacy status label is shown in the dispensed item card")
+@then("No pharmacy status label is shown in the item card")
 def no_pharmacy_status_labels(context):
     page = PrescriptionDetailsPage(context.page)
 

messages/eps_fhir/dispense_notification.py

@@ -195,6 +195,7 @@ def medication_dispense(self, practitioner_role, medication_request):
                         {
                             "system": self.HTTP_SNOMED_INFO_SCT,
                             "code": "322237000",
+                            "display": "Paracetamol 500mg soluble tablet (product)",
                         }
                     ]
                 },

messages/eps_fhir/prescription.py

@@ -151,6 +151,7 @@ def create_medication_request(self):
                         {
                             "system": "http://snomed.info/sct",  # http only
                             "code": "322237000",
+                            "display": "Paracetamol 500mg soluble tablet (product)",
                         }
                     ]
                 },

pages/prescription_details.py

@@ -29,12 +29,6 @@ def __init__(self, page: Page):
 
         # Summary details
         self.prescription_summary = page.get_by_test_id("prescription-summary-list")
-        self.initial_prescription_details = page.get_by_test_id(
-            "initial-prescription-details"
-        )
-        self.initial_prescription_summary = page.get_by_test_id(
-            "initial-prescription-summary-list"
-        )
 
         # EPS status tag
         self.eps_status_tag = page.get_by_test_id("eps-status-tag")