New: [AEA-6037] - Introduce PFP on Proxygen tests using a unique product ID (#526)

## Summary

- ✨ New Feature

### Details

Add in PFP-Proxygen product & feature set for temporary base path.

---------

Signed-off-by: Connor Avery <[email protected]>

Author: connoravo-nhs

.github/workflows/regression_tests.yml

@@ -22,6 +22,7 @@ on:
           - EPS-FHIR-PRESCRIBING
           - EPS-FHIR-DISPENSING
           - PFP-APIGEE
+          - PFP-PROXYGEN
           - PFP-AWS
           - PSU
           - EPS-ASSIST-ME

features/environment.py

@@ -161,6 +161,7 @@
 EPS_FHIR_PRESCRIBING_SUFFIX = "fhir-prescribing"
 EPS_FHIR_DISPENSING_SUFFIX = "fhir-dispensing"
 PFP_SUFFIX = "prescriptions-for-patients"
+PFP_PROXYGEN_SUFFIX = "pfp-proxygen"
 PSU_SUFFIX = "prescription-status-update"
 
 EPSAM_SLACKBOT_FUNCTION_EXPORT_NAME = (
@@ -361,12 +362,19 @@ def before_all(context):
         context.eps_fhir_dispensing_base_url = os.path.join(
             select_apigee_base_url(env), EPS_FHIR_DISPENSING_SUFFIX
         )
-        context.pfp_base_url = os.path.join(select_apigee_base_url(env), PFP_SUFFIX)
         context.psu_base_url = os.path.join(select_apigee_base_url(env), PSU_SUFFIX)
         context.cpts_fhir_base_url = os.path.join(
             select_apigee_base_url(env), CPTS_FHIR_SUFFIX
         )
 
+        if "PFP-PROXYGEN" in product:
+            # Don't use PFP-PROXYGEN AND PFP-APIGEE TOGETHER
+            context.pfp_base_url = os.path.join(
+                select_apigee_base_url(env), PFP_PROXYGEN_SUFFIX
+            )
+        else:
+            context.pfp_base_url = os.path.join(select_apigee_base_url(env), PFP_SUFFIX)
+
         get_function_export_name(context)
 
         if PULL_REQUEST_ID and env != "LOCALHOST":
@@ -435,6 +443,10 @@ def get_url_with_pr(context, env, product):
         context.pfp_base_url = os.path.join(
             INTERNAL_DEV_BASE_URL, f"{PFP_SUFFIX}-{pull_request_id}"
         )
+    if product == "PFP-PROXYGEN":
+        context.pfp_base_url = os.path.join(
+            INTERNAL_DEV_BASE_URL, f"{PFP_PROXYGEN_SUFFIX}-{pull_request_id}"
+        )
     if product == "PSU":
         context.psu_base_url = os.path.join(
             INTERNAL_DEV_BASE_URL, f"{PSU_SUFFIX}-{pull_request_id}"

features/pfp/get_my_prescriptions.feature

@@ -0,0 +1,69 @@
+@pfp_proxygen @pfp_aws @regression
+Feature: I can see my prescriptions via PFP Proxygen
+
+  @blocker @smoke @e2e @allure.tms:https://nhsd-jira.digital.nhs.uk/browse/AEA-4222
+  Scenario: I can see a single prescription
+    Given I am an authorised prescriber with EPS-FHIR-PRESCRIBING app
+    And I successfully prepare and sign a prescription
+    When I am authenticated with PFP-PROXYGEN app
+    And I request my prescriptions
+    Then I can see my prescription
+
+  # Spine defined limit of 25 prescriptions per request
+  Scenario: I can see a maximum of 25 prescriptions
+    Given I am an authorised prescriber with EPS-FHIR-PRESCRIBING app
+    And I successfully prepare and sign '26' nominated acute prescriptions
+    When I am authenticated with PFP-PROXYGEN app
+    And I request my prescriptions
+    Then I can see '25' of my prescriptions
+
+  # FLAKY WARNING: We've agreed to rely on NHS random generation to return an NHS number without prescriptions
+  # This may cause flakiness if the random NHS number happens to have prescriptions
+  Scenario: I can see no prescriptions
+    Given I am an authorised prescriber with EPS-FHIR-PRESCRIBING app
+    And I successfully prepare and sign '0' nominated acute prescriptions
+    When I am authenticated with PFP-PROXYGEN app
+    And I request my prescriptions
+    Then I can see '0' of my prescriptions
+
+  Scenario: I cannot see unreleased prescriptions
+    Given I am an authorised prescriber with EPS-FHIR-PRESCRIBING app
+    And I successfully prepare a nominated acute prescription
+    When I am authenticated with PFP-PROXYGEN app
+    And I request my prescriptions
+    Then I cannot see my unreleased prescriptions
+
+  Scenario: I cannot see eRD prescription items
+    Given I am an authorised prescriber with EPS-FHIR-PRESCRIBING app
+    And I successfully prepare and sign a nominated eRD prescription
+    When I am authenticated with PFP-PROXYGEN app
+    And I request my prescriptions
+    Then I do not see an eRD prescription
+
+  Scenario: I can see a FHIR compliant response for my prescriptions
+    Given I am an authorised prescriber with EPS-FHIR-PRESCRIBING app
+    And I successfully prepare and sign a nominated acute prescription
+    When I am authenticated with PFP-PROXYGEN app
+    And I request my prescriptions
+    Then I validate the prescription matches my prepared prescription
+
+  @e2e
+  Scenario: I can see prescription item status (multiple statuses, multiple items) - acute, repeat
+    Given I am an authorised prescriber with EPS-FHIR-PRESCRIBING app
+    And I successfully prepare and sign '2' nominated acute prescriptions
+    And I am an authorised dispenser with EPS-FHIR-DISPENSING app
+    And I release all prescriptions
+    When I set the statuses I will update through
+      | Status        |
+      | With Pharmacy |
+    Then I process the status updates for the prescription items and verify they are returned
+
+# # This scenario requires changes to FHIR compliance endpoint to be able to validate PFP responses
+# # Scenario: I can see prescription item details in FHIR compliant response
+# #   Given I am an authorised prescriber with EPS-FHIR-PRESCRIBING app
+# #   And I successfully prepare and sign a prescription
+# #   When I am authenticated with PFP-PROXYGEN app
+# #   And I request my prescriptions
+# #   Then I am an authorised prescriber with EPS-FHIR app
+# #   And I validate the response for FHIR compliance
+# #   And the response indicates a success

methods/shared/common.py

@@ -35,10 +35,9 @@ def get_psu_authenticator(env, url):
         jwt_kid=JWT_KID,
     )
     # 2. Pass the config to the Authenticator
-    authenticator = ClientCredentialsAuthenticator(
-        config=config  # pyright: ignore [reportArgumentType]
-    )
-
+    # fmt: off
+    authenticator = ClientCredentialsAuthenticator(config=config)  # pyright: ignore [reportArgumentType]
+    # fmt: on
     return authenticator
 
 
@@ -62,9 +61,9 @@ def get_eps_fhir_authenticator(user, env, url, product):
         scope=scope,
         login_form=login_form,
     )
-    authenticator = AuthorizationCodeAuthenticator(
-        config=config  # pyright: ignore [reportArgumentType]
-    )
+    # fmt: off
+    authenticator = AuthorizationCodeAuthenticator(config=config)  # pyright: ignore [reportArgumentType]
+    # fmt: on
     return authenticator
 
 
@@ -88,9 +87,9 @@ def get_pfp_apigee_authenticator(env, url):
         scope=scope,
         login_form=login_form,
     )
-    authenticator = AuthorizationCodeAuthenticator(
-        config=config  # pyright: ignore [reportArgumentType]
-    )
+    # fmt: off
+    authenticator = AuthorizationCodeAuthenticator(config=config)  # pyright: ignore [reportArgumentType]
+    # fmt: on
     return authenticator
 
 
@@ -104,6 +103,7 @@ def get_auth(env, product, user="prescriber"):
         "EPS-FHIR-PRESCRIBING-SHA1",
         "EPS-FHIR-DISPENSING",
         "PFP-APIGEE",
+        "PFP-PROXYGEN",
         "PSU",
         "EPS-ASSIST-ME",
     ]:
@@ -119,7 +119,7 @@ def get_auth(env, product, user="prescriber"):
         "EPS-FHIR-PRESCRIBING-SHA1",
     ]:
         authenticator = get_eps_fhir_authenticator(user, env, url, product)
-    if product == "PFP-APIGEE":
+    if product == "PFP-APIGEE" or product == "PFP-PROXYGEN":
         authenticator = get_pfp_apigee_authenticator(env, url)
     if product == "PSU":
         authenticator = get_psu_authenticator(env, url)