Defend against setting PR ID and localhost at the same time

Author: wildjames

README.md

@@ -79,7 +79,7 @@ For example:
 product=cpts-ui env=internal-dev PULL_REQUEST_ID=pr-300 tags=cpt-ui HEADLESS=true make run-tests
 ```
 
-Note that CPT-UI supports localhost testing. To do this, use the `env=localhost` variable. Make sure your localhost server is running!
+Note that CPT-UI supports localhost testing. To do this, use the `env=localhost` variable - but ensure you have *not* set the `PULL_REQUEST_ID` variable, as it is not needed and will break the tests. Make sure your localhost server is running!
 
 ### Method 4 (Not Recommended):
 Run the tests by running `behave` in a command prompt or terminal window.

features/environment.py

@@ -135,7 +135,7 @@ def before_all(context):
         context.pfp_base_url = os.path.join(select_apigee_base_url(env), PFP_SUFFIX)
         context.psu_base_url = os.path.join(select_apigee_base_url(env), PSU_SUFFIX)
 
-        if PULL_REQUEST_ID:
+        if PULL_REQUEST_ID and env != "LOCALHOST":
             print(f"--- Using pull request id: '{PULL_REQUEST_ID}'")
             pull_request_id = PULL_REQUEST_ID.lower()
             if "pr-" in pull_request_id: