Skip to content

Commit 23a4c94

Browse files
committed
eja - amending make commands to allow for environment specific builds of spec, and updating sandbox commands to make use of this
1 parent 3fd55b3 commit 23a4c94

File tree

4 files changed

+4
-5
lines changed

4 files changed

+4
-5
lines changed

Makefile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,9 +127,7 @@ construct-spec: guard-APIM_ENV
127127
mkdir -p build/specification/$(APIM_ENV) && \
128128
npx redocly bundle specification/eligibility-signposting-api.yaml --remove-unused-components --keep-url-references --ext yaml \
129129
> build/specification/$(APIM_ENV)/eligibility-signposting-api.yaml
130-
ifeq ($(APIM_ENV),sandbox)
131-
yq 'del(.components.securitySchemes)' build/specification/sandbox/eligibility-signposting-api.yaml > build/specification/sandbox/eligibility-signposting-api.yaml.tmp && mv build/specification/sandbox/eligibility-signposting-api.yaml.tmp build/specification/sandbox/eligibility-signposting-api.yaml
132-
endif
130+
133131

134132
SPEC_DIR := $(CURDIR)/specification
135133
POSTMAN_DIR := $(SPEC_DIR)/postman

sandbox/Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ update:
2525

2626
spec:
2727
mkdir -p specification
28+
make -C .. construct-spec APIM_ENV=sandbox
2829
make -C .. generate-sandbox-spec
2930

3031
test:

specification/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ We deploy our specifications using the Proxygen CLI. In order to do this, the fo
4141
2. Activate a poetry environment `poetry env activate` - you may need to run `make install-python` to install poetry etc. first.
4242
3. Run `make retrieve-proxygen-key` from the root directory to retrieve the private key needed to authenticate with Proxygen.
4343
4. Run `make setup-proxygen-credentials` from the root directory to set up credentials needed to interact with our API proxy.
44-
5. Run `proxygen instance deploy <environment> eligibility-signposting-api ./build/specification/eligibility-signposting-api.yaml` to deploy the specification to
44+
5. Run `proxygen instance deploy <environment> eligibility-signposting-api ./build/specification/<env>/eligibility-signposting-api.yaml` to deploy the specification to
4545
a chosen environment.
4646

4747
### Publishing specifications

specification/eligibility-signposting-api.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
openapi: 3.0.1
1+
openapi: 3.0.3
22
info:
33
title: Patient Eligibility Signposting API
44
version: 1.0.10-alpha

0 commit comments

Comments
 (0)