sonar fix

Author: Karthikeyannhs

src/eligibility_signposting_api/config/config.py

@@ -23,7 +23,6 @@ def config() -> dict[str, Any]:
     rules_bucket_name = BucketName(os.getenv("RULES_BUCKET_NAME", "test-rules-bucket"))
     audit_bucket_name = BucketName(os.getenv("AUDIT_BUCKET_NAME", "test-audit-bucket"))
     aws_default_region = AwsRegion(os.getenv("AWS_DEFAULT_REGION", "eu-west-1"))
-    api_domain_name = ApiDomainName(os.getenv("API_DOMAIN_NAME", "localhost"))
     enable_xray_patching = bool(os.getenv("ENABLE_XRAY_PATCHING", "false"))
     kinesis_audit_stream_to_s3 = AwsKinesisFirehoseStreamName(
         os.getenv("KINESIS_AUDIT_STREAM_TO_S3", "test_kinesis_audit_stream_to_s3")
@@ -41,7 +40,6 @@ def config() -> dict[str, Any]:
             "rules_bucket_name": rules_bucket_name,
             "audit_bucket_name": audit_bucket_name,
             "firehose_endpoint": None,
-            "api_domain_name": api_domain_name,
             "kinesis_audit_stream_to_s3": kinesis_audit_stream_to_s3,
             "enable_xray_patching": enable_xray_patching,
             "log_level": log_level,
@@ -58,7 +56,6 @@ def config() -> dict[str, Any]:
         "rules_bucket_name": rules_bucket_name,
         "audit_bucket_name": audit_bucket_name,
         "firehose_endpoint": URL(os.getenv("FIREHOSE_ENDPOINT", local_stack_endpoint)),
-        "api_domain_name": api_domain_name,
         "kinesis_audit_stream_to_s3": kinesis_audit_stream_to_s3,
         "enable_xray_patching": enable_xray_patching,
         "log_level": log_level,

src/eligibility_signposting_api/views/eligibility.py

@@ -1,12 +1,13 @@
 import logging
+import os
 import uuid
 from datetime import UTC, datetime
 from http import HTTPStatus
-from typing import Annotated, Any
+from typing import Any
 
 from flask import Blueprint, make_response, request
 from flask.typing import ResponseReturnValue
-from wireup import Inject, Injected
+from wireup import Injected
 
 from eligibility_signposting_api.audit.audit_context import AuditContext
 from eligibility_signposting_api.audit.audit_service import AuditService
@@ -35,8 +36,8 @@ def before_request() -> None:
 
 
 @eligibility_blueprint.get("/_status")
-def api_status(api_domain_name: Annotated[str, Inject(param="api_domain_name")]) -> ResponseReturnValue:
-    return make_response(build_status_payload(api_domain_name), HTTPStatus.OK)
+def api_status() -> ResponseReturnValue:
+    return make_response(build_status_payload(), HTTPStatus.OK)
 
 
 @eligibility_blueprint.get("/", defaults={"nhs_number": ""})
@@ -179,7 +180,8 @@ def build_suitability_results(condition: Condition) -> list[eligibility_response
     ]
 
 
-def build_status_payload(api_domain_name: str) -> dict:
+def build_status_payload() -> dict:
+    api_domain_name = os.getenv("API_DOMAIN_NAME", "localhost")
     return {
         "status": "pass",
         "version": "",