validate attribute target

Author: Karthikeyannhs

src/rules_validation_api/validators/iteration_rules_validator.py

@@ -1,7 +1,8 @@
 import typing
 
-from pydantic import model_validator
+from pydantic import field_validator, model_validator
 
+from eligibility_signposting_api.config.constants import ALLOWED_CONDITIONS
 from eligibility_signposting_api.model.campaign_config import (
     IterationRule,
     RuleAttributeLevel,
@@ -11,6 +12,19 @@
 
 
 class IterationRuleValidation(IterationRule):
+    @field_validator("attribute_target")
+    @classmethod
+    def validate_attribute_target(cls, value: str) -> str | None:
+        if value is None:
+            return value
+
+        allowed = ALLOWED_CONDITIONS.__args__
+        if value not in allowed:
+            allowed_str = ", ".join(allowed)
+            msg = f"Invalid attribute_target value: {value}. Allowed values: {allowed_str}"
+            raise ValueError(msg)
+        return value
+
     @model_validator(mode="after")
     def check_cohort_attribute_name(self) -> typing.Self:
         if (

tests/unit/validation/test_iteration_rules_validator.py

@@ -203,14 +203,14 @@ def test_invalid_cohort_label(self, label, valid_iteration_rule_with_only_mandat
             IterationRuleValidation(**data)
 
     # AttributeTarget
-    @pytest.mark.parametrize("target", ["target_value"])
+    @pytest.mark.parametrize("target", ["RSV", "COVID"])
     def test_valid_attribute_target(self, target, valid_iteration_rule_with_only_mandatory_fields):
         data = valid_iteration_rule_with_only_mandatory_fields.copy()
         data["AttributeTarget"] = target
         result = IterationRuleValidation(**data)
         assert result.attribute_target == target
 
-    @pytest.mark.parametrize("target", [123, [], {}])
+    @pytest.mark.parametrize("target", [123, [], {}, "RSV1"])
     def test_invalid_attribute_target(self, target, valid_iteration_rule_with_only_mandatory_fields):
         data = valid_iteration_rule_with_only_mandatory_fields.copy()
         data["AttributeTarget"] = target