eli-239 renaming external role to a more identifiable name

eddalmond1 · eddalmond1 · commit 36e380476d43 · 2025-06-03T15:42:35.000+01:00
diff --git a/infrastructure/stacks/api-layer/iam_roles.tf b/infrastructure/stacks/api-layer/iam_roles.tf
@@ -31,7 +31,8 @@ resource "aws_iam_role" "eligibility_lambda_role" {
 
 
 resource "aws_iam_role" "write_access_role" {
-  name                 = "external-write-role-${terraform.workspace == "default" ? "" : "-${terraform.workspace}"}"
+  count                = terraform.workspace == "default" ? 1 : 0
+  name                 = "eligibility-signposting-api-${local.environment}-external-write-role"
   assume_role_policy   = data.aws_iam_policy_document.dps_assume_role.json
   permissions_boundary = aws_iam_policy.assumed_role_permissions_boundary.arn
 }

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,8 @@ resource "aws_iam_role" "eligibility_lambda_role" {`
`31`	`31`
`32`	`32`
`33`	`33`	`resource "aws_iam_role" "write_access_role" {`
`34`		`- name = "external-write-role-${terraform.workspace == "default" ? "" : "-${terraform.workspace}"}"`
	`34`	`+ count = terraform.workspace == "default" ? 1 : 0`
	`35`	`+ name = "eligibility-signposting-api-${local.environment}-external-write-role"`
`35`	`36`	`assume_role_policy = data.aws_iam_policy_document.dps_assume_role.json`
`36`	`37`	`permissions_boundary = aws_iam_policy.assumed_role_permissions_boundary.arn`
`37`	`38`	`}`