eli 441 update base-deploy to change artefacts name based on the input ref (#441)

* update base-deploy to change artefacts name based on the input ref

* reduce size by keeping botocore and boto3 in sync

Author: Karthikeyannhs

.github/workflows/base-deploy.yml

@@ -220,12 +220,6 @@ jobs:
           echo "bucket_name=$BUCKET" >> $GITHUB_OUTPUT
         working-directory: ./infrastructure/stacks/api-layer
 
-      - name: "Upload lambda artifact to S3"
-        run: |
-          aws s3 cp ./dist/lambda.zip \
-            s3://${{ steps.tf_output.outputs.bucket_name }}/artifacts/${{ needs.metadata.outputs.tag }}/lambda.zip \
-            --region eu-west-2
-
       - name: "Validate Feature Toggles"
         env:
           ENV: ${{ needs.metadata.outputs.environment }}
@@ -245,6 +239,17 @@ jobs:
           pip install requests
           python scripts/workflow/tag_and_release.py
 
+      - name: "Capture release tag"
+        id: release_tag
+        run: |
+          echo "release_tag=$(cat release_tag.txt)" >> $GITHUB_OUTPUT
+
+      - name: "Upload lambda artifact to S3"
+        run: |
+          aws s3 cp ./dist/lambda.zip \
+            s3://${{ steps.tf_output.outputs.bucket_name }}/artifacts/${{ steps.release_tag.outputs.release_tag }}/lambda.zip \
+            --region eu-west-2
+
 
   regression-tests:
     name: "Regression Tests"

.github/workflows/cicd-4-preprod-deploy.yml

@@ -8,9 +8,8 @@ on:
   workflow_dispatch:
     inputs:
       ref:
-        description: "Branch/Tag/SHA to deploy to preprod (dev tag)"
+        description: "Tag to deploy to preprod (dev tag)"
         required: true
-        default: "main"
       release_type:
         description: "Version bump type (use 'rc' to keep the same base and just increment RC)"
         required: true