[ELI-137] Base Logging config change

* base logging setup

* getting log level from env and revoke name change for func logging config

* Failing linting should fail the build pipeline.

* lint fixes

* Linting needs poetry.

* Misc/dev setup changes (#26)

* Pin localstack image version.

* Use http://localstack:4566/ as default endpoint for lambda <-> communication within localstack.

* Pin sam/build-python image version.

* Formatting fix.

* Shorten env var name LOCALSTACK_INTERNAL_DYNAMODB_ENDPOINT

* Try to fix sonarqube coverage reporting. (#24)

* adding changes

---------

Co-authored-by: Simon Brunning <[email protected]>
Co-authored-by: TOEL2 <[email protected]>

Author: 3 people

scripts/tests/lint.sh

@@ -0,0 +1,7 @@
+#!/bin/bash
+
+set -euo pipefail
+
+cd "$(git rev-parse --show-toplevel)"
+
+make dependencies install-python lint

src/eligibility_signposting_api/app.py

@@ -13,6 +13,9 @@
 from eligibility_signposting_api.views.eligibility import eligibility
 from eligibility_signposting_api.views.hello import hello
 
+init_logging()
+logger = logging.getLogger(__name__)
+
 
 def main() -> None:  # pragma: no cover
     """Run the Flask app as a local process."""
@@ -27,10 +30,8 @@ def lambda_handler(event: LambdaEvent, context: LambdaContext) -> dict[str, Any]
 
 
 def create_app() -> Flask:
-    init_logging()
-
     app = Flask(__name__)
-    app.logger.info("app created")
+    logger.info("app created")
 
     # Register views & error handler
     app.register_blueprint(eligibility, url_prefix="/eligibility")
@@ -41,7 +42,7 @@ def create_app() -> Flask:
     container = wireup.create_container(service_modules=[services, repos], parameters=config())
     wireup.integration.flask.setup(container, app, import_flask_config=True)
 
-    app.logger.info("app ready")
+    logger.info("app ready")
     return app
 
 

src/eligibility_signposting_api/config.py

@@ -1,11 +1,10 @@
 import logging
 import os
-from logging.config import dictConfig
 from typing import Any, NewType
 
 from yarl import URL
 
-LOG_LEVEL = logging.DEBUG
+LOG_LEVEL = logging.getLevelNamesMapping().get(os.getenv("LOG_LEVEL", ""), logging.WARNING)
 
 AwsRegion = NewType("AwsRegion", str)
 AwsAccessKey = NewType("AwsAccessKey", str)
@@ -22,22 +21,5 @@ def config() -> dict[str, Any]:
 
 
 def init_logging() -> None:
-    level = logging.getLevelName(LOG_LEVEL)
     log_format = "%(asctime)s %(levelname)-8s %(name)s %(module)s.py:%(funcName)s():%(lineno)d %(message)s"
-    dictConfig(
-        {
-            "version": 1,
-            "formatters": {
-                "default": {
-                    "format": log_format,
-                }
-            },
-            "handlers": {
-                "wsgi": {"class": "logging.StreamHandler", "stream": "ext://sys.stdout", "formatter": "default"}
-            },
-            "root": {"level": level, "handlers": ["wsgi"]},
-            "loggers": {
-                "eligibility_signposting_api.app": {"level": level, "handlers": ["wsgi"], "propagate": False},
-            },
-        }
-    )
+    logging.basicConfig(level=LOG_LEVEL, format=log_format, handlers=[logging.StreamHandler()])