modify base deploy to reuse lambda artifact

Author: Karthikeyannhs

.github/workflows/base-deploy.yml

@@ -32,6 +32,7 @@ jobs:
       terraform_version: ${{ steps.variables.outputs.terraform_version }}
       ref: ${{ steps.variables.outputs.ref }}
       environment: ${{ steps.variables.outputs.environment }}
+      tag: ${{ steps.tag.outputs.name }}
     steps:
       - name: "Checkout ref"
         uses: actions/checkout@v5
@@ -74,6 +75,62 @@ jobs:
           echo "ref=$REF"
           echo "environment=$ENVIRONMENT"
 
+      - name: "Resolve the dev-* tag for this commit"
+        id: tag
+        run: |
+          git fetch --tags --force
+          SHA="${{ github.event.workflow_run.head_sha }}"
+          TAG=$(git tag --points-at "$SHA" | grep '^dev-' | head -n1 || true)
+          if [ -z "$TAG" ]; then
+            echo "No dev-* tag found on $SHA" >&2
+            exit 1
+          fi
+          echo "name=$TAG" >> $GITHUB_OUTPUT
+          echo "Resolved tag: $TAG"
+
+  download-lambda-artifact:
+      name: "Fetch the lambda artifact from previous stage"
+      runs-on: ubuntu-latest
+      needs: [metadata]
+      timeout-minutes: 45
+      permissions:
+        id-token: write
+        contents: write
+      env:
+        PROMOTED_ENV: ${{
+          contains(needs.metadata.outputs.environment, 'preprod') && 'test' ||
+          contains(needs.metadata.outputs.environment, 'prod') && 'preprod' ||
+          needs.metadata.outputs.environment
+        }}
+      environment: ${{ env.PROMOTED_ENV }}
+      steps:
+        - name: "Checkout repository at ref"
+          uses: actions/checkout@v5
+          with:
+            ref: ${{ needs.metadata.outputs.ref }}
+            fetch-depth: 0
+
+        - name: "Extract S3 bucket name from Terraform output"
+          id: tf_output
+          run: |
+            BUCKET=$(terraform output -raw lambda_artifact_bucket)
+            echo "bucket_name=$BUCKET" >> $GITHUB_OUTPUT
+          working-directory: ./infrastructure/stacks/api-layer
+
+        - name: "Download lambda artifact from S3"
+          run: |
+            aws s3 cp \
+              s3://${{ steps.tf_output.outputs.bucket_name }}/artifacts/${{ needs.metadata.outputs.tag }}/lambda.zip \
+              ./build/lambda.zip \
+              --region eu-west-2
+
+        - name: "Upload lambda artifact for the current workflow"
+          uses: actions/upload-artifact@v4
+          with:
+            name: lambda-${{ needs.metadata.outputs.tag }}
+            path: ./build/lambda.zip
+
+
   deploy:
     name: "Deploy to ${{ needs.metadata.outputs.environment }}"
     runs-on: ubuntu-latest
@@ -95,36 +152,10 @@ jobs:
         with:
           terraform_version: ${{ needs.metadata.outputs.terraform_version }}
 
-      - name: "Install Poetry"
-        run: |
-          curl -sSL https://install.python-poetry.org | python3 -
-          echo "$HOME/.local/bin" >> $GITHUB_PATH
-
-      - name: "Set up Python"
-        uses: actions/setup-python@v6
-        with:
-          python-version: "3.13"
-          cache: 'poetry'
-
-      - name: "Install dependencies"
-        run: poetry install
-
-      - name: "Build lambda artefact"
-        shell: bash
-        run: |
-          make dependencies install-python
-          make build
-
-      - name: "Upload lambda artefact"
-        uses: actions/upload-artifact@v4
-        with:
-          name: lambda
-          path: dist/lambda.zip
-
-      - name: "Download Built Lambdas"
+      - name: "Download Lambda Artifact"
         uses: actions/download-artifact@v5
         with:
-          name: lambda
+          name: lambda-${{ needs.metadata.outputs.tag }}
           path: ./build
 
       - name: "Configure AWS Credentials"
@@ -153,6 +184,19 @@ jobs:
           echo "Running: make terraform env=$ENVIRONMENT workspace=$WORKSPACE stack=api-layer tf-command=apply"
           make terraform env=$ENVIRONMENT stack=api-layer tf-command=apply workspace=$WORKSPACE
 
+      - name: "Extract S3 bucket name from Terraform output"
+        id: tf_output
+        run: |
+          BUCKET=$(terraform output -raw lambda_artifact_bucket)
+          echo "bucket_name=$BUCKET" >> $GITHUB_OUTPUT
+        working-directory: ./infrastructure/stacks/api-layer
+
+      - name: "Upload lambda artifact to S3"
+        run: |
+          aws s3 cp ./build/lambda.zip \
+            s3://${{ steps.tf_output.outputs.bucket_name }}/artifacts/${{ needs.metadata.outputs.tag }}/lambda.zip \
+            --region eu-west-2
+
       - name: "Validate Feature Toggles"
         env:
           ENV: ${{ needs.metadata.outputs.environment }}

.github/workflows/cicd-2-publish.yaml

@@ -116,6 +116,19 @@ jobs:
           make terraform env=$ENVIRONMENT stack=api-layer tf-command=apply workspace=$WORKSPACE
         working-directory: ./infrastructure
 
+      - name: "Extract S3 bucket name from Terraform output"
+        id: tf_output
+        run: |
+          BUCKET=$(terraform output -raw lambda_artifact_bucket)
+          echo "bucket_name=$BUCKET" >> $GITHUB_OUTPUT
+        working-directory: ./infrastructure/stacks/api-layer
+
+      - name: "Upload lambda artifact to S3"
+        run: |
+          aws s3 cp ./build/lambda.zip \
+            s3://${{ steps.tf_output.outputs.bucket_name }}/artifacts/${{ needs.metadata.outputs.tag }}/lambda.zip \
+            --region eu-west-2
+
       - name: "Tag the dev deployment"
         run: |
           git config user.name "github-actions"

.github/workflows/cicd-3-test-deploy.yaml

@@ -113,7 +113,7 @@ jobs:
       - name: "Upload lambda artifact to S3"
         run: |
           aws s3 cp ./build/lambda.zip \
-            s3://${{ steps.tf_output.outputs.bucket_name }}/artifacts/${{ needs.metadata.outputs.version }}/lambda.zip \
+            s3://${{ steps.tf_output.outputs.bucket_name }}/artifacts/${{ needs.metadata.outputs.tag }}/lambda.zip \
             --region eu-west-2
 
   regression-tests: