Feature/eja trial regression test workflow (#354)

* Amending regresion tests to see if can trigger without additional approval

* amending regression test to install poetry into setup-python version of python

* reverted python/poetry step (hopefully we didn't need to change this)
added check-licenses to make file
updated script

* returned the echo which states which environment the tests will run in

* moving pip-licences to dev dependencies

* updating poetry lock

---------

Co-authored-by: SeanSteberis <[email protected]>

Author: eddalmond1

.github/workflows/cicd-3-test.yaml

@@ -130,9 +130,11 @@ jobs:
           echo "Running: make terraform env=$ENVIRONMENT workspace=$WORKSPACE stack=api-layer tf-command=apply"
           make terraform env=$ENVIRONMENT stack=api-layer tf-command=apply workspace=$WORKSPACE
         working-directory: ./infrastructure
-
-      - name: "Regression Tests"
-        uses: ./.github/workflows/regression-tests.yml
-        with:
-          ENVIRONMENT: "test"
-          VERSION_NUMBER: "main"
+  regression-tests:
+    name: "Regression Tests"
+    needs: deploy
+    uses: ./.github/workflows/regression-tests.yml
+    with:
+      ENVIRONMENT: "test"
+      VERSION_NUMBER: "main"
+    secrets: inherit

.github/workflows/regression-tests.yml

@@ -11,19 +11,15 @@ on:
         type: string
       PRODUCT:
         type: string
-    secrets: {}
-
+    secrets: { }
 
 jobs:
   regression-tests:
-    runs-on: ubuntu-latest
-    environment: ${{ inputs.ENVIRONMENT }}
-
+    runs-on: ubuntu-22.04
     steps:
-      - name: Checkout local github actions
+      - name: Checkout
         uses: actions/checkout@v5
         with:
-          ref: ${{ env.BRANCH_NAME }}
           fetch-depth: 0
 
       - name: Cache asdf
@@ -35,15 +31,14 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-asdf-
 
-      - name: Install asdf dependencies in .tool-versions
+      - name: Install asdf tools
         uses: asdf-vm/actions/install@1902764435ca0dd2f3388eea723a4f92a4eb8302
         with:
           asdf_branch: v0.15.0
         env:
           PYTHON_CONFIGURE_OPTS: --enable-shared
 
-      # Use grep to find the line beginning with "python"
-      - name: Get Python version from file
+      - name: Derive Python version from .tool-versions
         run: |
           PYTHON_VERSION=$(grep "^python" .tool-versions | sed 's/python //g')
           echo "PYTHON_VERSION=$PYTHON_VERSION" >> $GITHUB_ENV
@@ -66,6 +61,6 @@ jobs:
         run: |
           echo Running regression tests in the "$TARGET_ENVIRONMENT" environment.
           poetry run python run_regression_tests.py \
-          --env="$TARGET_ENVIRONMENT" \
-          --token="$TESTS_TOKEN" \
-          --regression_test_repo_tag "$VERSION_NUMBER"
+            --env="$TARGET_ENVIRONMENT" \
+            --token="$TESTS_TOKEN" \
+            --regression_test_repo_tag "$VERSION_NUMBER"

Makefile

@@ -36,6 +36,9 @@ _dist_include="pytest.ini poetry.lock poetry.toml pyproject.toml Makefile build/
 dependencies: # Install dependencies needed to build and test the project @Pipeline
 	scripts/dependencies.sh
 
+check-licenses:
+	scripts/check_python_licenses.sh
+
 .PHONY: build
 build: dist/lambda.zip # Build lambda.zip in dist/
 

poetry.lock

@@ -64,6 +64,8 @@ behave = "^1.2.6"
 boto3 = "^1.38.42"
 python-dotenv = "^1.1.1"
 openapi-spec-validator = "^0.7.2"
+pip-licenses = "^5.0.0"
+
 
 [tool.poetry-plugin-lambda-build]
 docker-image = "public.ecr.aws/sam/build-python3.13:1.139-x86_64"  # See https://gallery.ecr.aws/search?searchTerm=%22python%22&architecture=x86-64&popularRegistries=amazon&verified=verified&operatingSystems=Linux

pyproject.toml

@@ -7,6 +7,7 @@ LICENSES=$(poetry run pip-licenses  --ignore-packages "${IGNORE_PACKAGES}")
 INCOMPATIBLE_LIBS=$(echo "$LICENSES" | grep 'GPL' || true)
 
 if [[ -z $INCOMPATIBLE_LIBS ]]; then
+    echo "The libraries were checked and no license issues were found."
     exit 0
 else
     echo "The following libraries were found which are not compatible with this project's license:"