lint fixes

Author: Karthikeyannhs

src/rules_validation_api/validators/actions_mapper_validator.py

@@ -1,5 +1,13 @@
+from pydantic import model_validator
+
 from eligibility_signposting_api.model.campaign_config import ActionsMapper
 
 
 class ActionsMapperValidator(ActionsMapper):
-    pass
+    @model_validator(mode="after")
+    def validate_keys(self) -> "ActionsMapperValidator":
+        invalid_keys = [key for key in self.root if key is None or key == ""]
+        if invalid_keys:
+            msg = f"Invalid keys found in ActionsMapper: {invalid_keys}"
+            raise ValueError(msg)
+        return self

tests/unit/validation/test_actions_mapper_validator.py

@@ -0,0 +1,49 @@
+import pytest
+from pydantic import ValidationError
+
+from eligibility_signposting_api.model.campaign_config import AvailableAction
+from rules_validation_api.validators.actions_mapper_validator import ActionsMapperValidator
+
+
+@pytest.fixture
+def valid_available_action():
+    return {
+        "ExternalRoutingCode": "BookNBS",
+        "ActionDescription": "",
+        "ActionType": "ButtonWithAuthLink",
+        "UrlLink": "http://www.nhs.uk/book-rsv",
+        "UrlLabel": "Continue to booking",
+    }
+
+
+class TestBUCValidations:
+    def make_action(self, data: dict) -> AvailableAction:
+        return AvailableAction(**data)
+
+    def test_valid_actions_mapper(self, valid_available_action):
+        data = {
+            "action1": self.make_action(valid_available_action),
+            "action2": self.make_action({**valid_available_action, "ExternalRoutingCode": "AltCode"}),
+        }
+        mapper = ActionsMapperValidator(root=data)
+
+        expected_action_count = 2
+        assert isinstance(mapper, ActionsMapperValidator)
+        assert len(mapper.root) == expected_action_count
+
+    def test_invalid_actions_mapper_empty_key(self, valid_available_action):
+        data = {"": self.make_action(valid_available_action), "action2": self.make_action(valid_available_action)}
+        with pytest.raises(ValidationError) as exc_info:
+            ActionsMapperValidator(root=data)
+        assert "Invalid keys found in ActionsMapper" in str(exc_info.value)
+        assert "['']" in str(exc_info.value)
+
+    @pytest.mark.parametrize("bad_key", [""])
+    def test_invalid_keys_parametrized(self, bad_key, valid_available_action):
+        data = {
+            bad_key: self.make_action(valid_available_action),
+            "valid_key": self.make_action(valid_available_action),
+        }
+        with pytest.raises(ValidationError) as exc_info:
+            ActionsMapperValidator(root=data)
+        assert "Invalid keys found in ActionsMapper" in str(exc_info.value)