Skip to content

Commit 5306fc3

Browse files
shweta-nhsKarthikeyannhs
authored andcommitted
ELI-351: Moves/deletes tests after refactoring (#265)
* ELI-351: Moves/deletes tests after refactoring * ELI-351: Extracts EligibilityResultBuilder and adds tests * ELI-351: De-extracts EligibilityResultBuilder and moves tests to Eligibility Calculator tests * ELI-351: Removes duplicated tests * ELI-351: Removes duplicated tests #2 * ELI-351: Adds validation and audit layer to Readme
1 parent 2a97d71 commit 5306fc3

File tree

4 files changed

+617
-2507
lines changed

4 files changed

+617
-2507
lines changed

README.md

Lines changed: 22 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -189,15 +189,25 @@ graph TB
189189
direction TB
190190
App["app.py (WireUp DI)"]
191191
Config["config.py, error_handler.py"]
192+
subgraph "Audit Layer"
193+
direction TB
194+
Audit["audit/audit_service.py"]
195+
AuditModels["audit/audit_models.py"]
196+
end
197+
subgraph "Validation Layer"
198+
direction TB
199+
Validator["common/request_validator.py"]
200+
ApiErrResp["common/api_error_response.py"]
201+
end
192202
subgraph "Presentation Layer"
193203
direction TB
194204
View["views/eligibility.py"]
195-
ResponseModel["views/response_model/eligibility.py"]
205+
ResponseModel["views/response_model/eligibility_response.py"]
196206
end
197207
subgraph "Business Logic Layer"
198208
direction TB
199209
Service["services/eligibility_services.py"]
200-
Operators["services/rules/operators.py"]
210+
Operators["services/operators/operators.py"]
201211
end
202212
subgraph "Data Access Layer"
203213
direction TB
@@ -207,24 +217,30 @@ graph TB
207217
end
208218
subgraph "Models"
209219
direction TB
210-
ModelElig["model/eligibility.py"]
211-
ModelRules["model/rules.py"]
220+
ModelElig["model/eligibility_status.py"]
221+
ModelRules["model/campaign_config.py"]
212222
end
213223
end
214224
215225
Lambda -->|"loads"| App
216226
App -->|injects| View
217227
View -->|calls| Service
228+
View -->|validates via| Validator
229+
View -->|audits via| Audit
230+
View -->|uses| RespModel
231+
Audit -->|uses| AuditModels
232+
Validator -->|uses| ApiErrResp
233+
218234
Service -->|calls| Operators
219235
Service -->|calls| PersonRepo
220236
Service -->|calls| CampaignRepo
221237
PersonRepo -->|uses| DynamoDB
222238
CampaignRepo -->|uses| S3Bucket
223-
View -->|uses| ResponseModel
224239
App -->|reads| Config
240+
App -->|wires| Factory
241+
225242
Service -->|uses| ModelElig
226243
Operators -->|uses| ModelRules
227-
App -->|wires| Factory
228244
229245
```
230246

0 commit comments

Comments
 (0)