eli-366 further linting and fixing pre-commit

Author: eddalmond1

scripts/config/pre-commit.yaml

@@ -51,7 +51,7 @@ repos:
         language: script
         pass_filenames: false
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.9.7
+    rev: v0.14.10
     hooks:
       - id: ruff
         args: [--fix]

tests/integration/conftest.py

@@ -228,7 +228,7 @@ def iam_role(iam_client: BaseClient) -> Generator[str]:
 
 @pytest.fixture(scope="session")
 def lambda_zip() -> Path:
-    build_result = subprocess.run(["make", "build"], capture_output=True, text=True, check=False)  # noqa: S603, S607
+    build_result = subprocess.run(["make", "build"], capture_output=True, text=True, check=False)  # noqa: S607
     assert build_result.returncode == 0, f"'make build' failed: {build_result.stderr}"
     return Path("dist/lambda.zip")
 

tests/unit/logging/test_logs_helper.py

@@ -5,6 +5,8 @@
 import pytest
 from mangum.types import LambdaContext
 
+from eligibility_signposting_api.app import log_request_ids_from_headers
+
 
 @pytest.fixture
 def lambda_context():
@@ -46,8 +48,6 @@ def lambda_context():
     ],
 )
 def test_log_request_ids_decorator_logs_metadata(headers, gateway_request_id, expected_extra, lambda_context, caplog):
-    from eligibility_signposting_api.app import log_request_ids_from_headers
-
     event = {"headers": headers}
     if gateway_request_id is not None:
         event["requestContext"] = {"requestId": gateway_request_id}

tests/unit/middleware/test_security_headers.py

@@ -3,7 +3,7 @@
 from http import HTTPStatus
 
 import pytest
-from flask import Flask
+from flask import Flask, make_response
 from flask.testing import FlaskClient
 from hamcrest import assert_that, contains_string, equal_to, has_entries, is_
 
@@ -152,8 +152,6 @@ def test_existing_headers_are_not_overridden(self) -> None:
 
         @app.route("/test")
         def test_route():
-            from flask import make_response
-
             resp = make_response({"status": "ok"}, HTTPStatus.OK)
             resp.headers["Cache-Control"] = "public, max-age=3600"
             return resp