eli-540 added logs

Author: Karthikeyannhs

src/eligibility_signposting_api/repos/person_repo.py

@@ -68,7 +68,7 @@ def get_eligibility_data(self, nhs_number: NHSNumber) -> Person:
             if nhs_hashed_with_previous:
                 items = self.get_person_record(nhs_hashed_with_previous)
                 if not items:
-                    logger.warning("No person record found for hashed nhs_number using secret AWSPREVIOUS")
+                    logger.warning("No person record found for hashed nhs_number using secret AWSPREVI")
                     message = "Person not found after checking AWSCURRENT and AWSPREVIOUS."
                     raise NotFoundError(message)
             else:
@@ -79,4 +79,5 @@ def get_eligibility_data(self, nhs_number: NHSNumber) -> Person:
                     message = "Person not found after checking AWSCURRENT, AWSPREVIOUS, and not hashed NHS numbers."
                     raise NotFoundError(message)
 
+        logger.info("Person record found")
         return Person(data=items)

src/eligibility_signposting_api/repos/secret_repo.py

@@ -26,12 +26,9 @@ def _get_secret_by_stage(self, secret_name: str, stage: str) -> dict[str, str]:
             return {stage: response["SecretString"]}
 
         except self.secret_manager.exceptions.ResourceNotFoundException:
-            logger.exception("Secret %s not found for stage %s", secret_name, stage)
+            logger.warning("Secret %s not found for stage %s", secret_name, stage)
             return {}
 
-        except ClientError:
-            logger.exception("Failed to get secret %s at stage %s", secret_name, stage)
-            return {}
 
     def get_secret_current(self, secret_name: str) -> dict[str, str]:
         return self._get_secret_by_stage(secret_name, "AWSCURRENT")