ELI 557 - Iteration id must be unique

Author: Karthikeyannhs

src/rules_validation_api/validators/campaign_config_validator.py

@@ -1,4 +1,5 @@
 import typing
+from collections import Counter
 from operator import attrgetter
 
 from pydantic import field_validator, model_validator
@@ -13,6 +14,16 @@ class CampaignConfigValidation(CampaignConfig):
     def validate_iterations(cls, iterations: list[Iteration]) -> list[IterationValidation]:
         return [IterationValidation(**i.model_dump()) for i in iterations]
 
+    @model_validator(mode="after")
+    def validate_iterations_have_unique_id(self) -> typing.Self:
+        ids = [iteration.id for iteration in self.iterations]
+        duplicates = {i_id for i_id, count in Counter(ids).items() if count > 1}
+        if duplicates:
+            raise ValueError(
+                f"Iterations contain duplicate IDs: {', '.join(duplicates)}"
+            )
+        return self
+
     @model_validator(mode="after")
     def validate_campaign_has_iteration_within_schedule(self) -> typing.Self:
         iterations_by_date = sorted(self.iterations, key=attrgetter("iteration_date"))

tests/unit/validation/conftest.py

@@ -34,6 +34,26 @@ def valid_campaign_config_with_only_mandatory_fields():
     }
 
 
+@pytest.fixture
+def valid_iteration_with_only_mandatory_fields():
+    return {
+        "ID": "ITER001",
+        "Version": 1,
+        "Name": "Mid-January Push",
+        "IterationDate": "20250102",
+        "IterationNumber": 1,
+        "ApprovalMinimum": 10,
+        "ApprovalMaximum": 100,
+        "Type": "A",
+        "DefaultCommsRouting": "",
+        "DefaultNotEligibleRouting": "",
+        "DefaultNotActionableRouting": "",
+        "IterationCohorts": [],
+        "IterationRules": [],
+        "ActionsMapper": {},
+    }
+
+
 @pytest.fixture
 def valid_iteration_rule_with_only_mandatory_fields():
     return {

tests/unit/validation/test_campaign_config_validator.py

@@ -233,3 +233,17 @@ def test_validate_iterations_non_empty(self, valid_campaign_config_with_only_man
             CampaignConfigValidation(**data)
         errors = error.value.errors()
         assert any(e["loc"][-1] == "Iterations" for e in errors), "Expected validation error on 'Iterations'"
+
+    def test_unique_iteration_ids(self, valid_campaign_config_with_only_mandatory_fields, valid_iteration_with_only_mandatory_fields):
+        data = valid_campaign_config_with_only_mandatory_fields.copy()
+        data["Iterations"].append(valid_iteration_with_only_mandatory_fields.copy())
+        data["Iterations"][1]["ID"] =  data["Iterations"][0]["ID"]
+        with pytest.raises(ValidationError) as exc_info:
+            CampaignConfigValidation(**data)
+
+        # Extract the error message
+        error_message = str(exc_info.value)
+
+        # Assert that the duplicate ID appears in the message
+        duplicate_id = data["Iterations"][0]["ID"]
+        assert f"Iterations contain duplicate IDs: {duplicate_id}" in error_message