ELI-442 upload artifacts to github with tags and reuse (#394)

* upload artifacts to github with tags

* sync test with dev artifact

* remove action that is not req

Author: Karthikeyannhs

.github/workflows/cicd-2-publish.yaml

@@ -80,16 +80,16 @@ jobs:
           make dependencies install-python
           make build
 
-      - name: "Upload lambda artefact"
+      - name: "Upload lambda artefact for cross-workflow use"
         uses: actions/upload-artifact@v4
         with:
-          name: lambda
+          name: lambda-${{ needs.metadata.outputs.version }}
           path: dist/lambda.zip
 
       - name: "Download Built Lambdas"
         uses: actions/download-artifact@v5
         with:
-          name: lambda
+          name: lambda-${{ needs.metadata.outputs.version }}
           path: ./build
 
       - name: "Configure AWS Credentials"

.github/workflows/cicd-3-test-deploy.yaml

@@ -78,10 +78,12 @@ jobs:
           role-to-assume: arn:aws:iam::${{ secrets.AWS_ACCOUNT_ID }}:role/service-roles/github-actions-api-deployment-role
           aws-region: eu-west-2
 
-      - name: "Build lambda artefact (rebuild in TEST)"
-        run: |
-          make dependencies install-python
-          make build
+      - name: "Download lambda artefact from dev workflow"
+        uses: actions/download-artifact@v5
+        with:
+          name: lambda-${{ needs.metadata.outputs.tag }}
+          path: ./build
+          run-id: ${{ github.event.workflow_run.id }}
 
       - name: "Terraform Apply (TEST)"
         env: