Remove obsolete fixture, and fix some names.

Author: acerathereinspirative-nhs-nvir

tests/integration/conftest.py

@@ -194,19 +194,6 @@ def wait_for_function_active(function_name, lambda_client):
                 raise FunctionNotActiveError
 
 
-@pytest.fixture(scope="session")
-def people_table(dynamodb_resource: ServiceResource) -> Generator[Any]:
-    table = dynamodb_resource.create_table(
-        TableName="People",
-        KeySchema=[{"AttributeName": "name", "KeyType": "HASH"}],
-        AttributeDefinitions=[{"AttributeName": "name", "AttributeType": "S"}],
-        ProvisionedThroughput={"ReadCapacityUnits": 5, "WriteCapacityUnits": 5},
-    )
-    table.wait_until_exists()
-    yield table
-    table.delete()
-
-
 @pytest.fixture(scope="session")
 def eligibility_table(dynamodb_resource: ServiceResource) -> Generator[Any]:
     table = dynamodb_resource.create_table(

tests/integration/lambda/test_app_running_as_lambda.py

@@ -79,7 +79,7 @@ def test_install_and_call_flask_lambda_over_http(
 def test_install_and_call_flask_lambda_with_unknown_nhs_number(
     flask_function_url: URL, flask_function: str, logs_client: BaseClient, faker: Faker
 ):
-    """Given lambda installed into localstack, run it via http, with a name nonexistent specified"""
+    """Given lambda installed into localstack, run it via http, with a nonexistent NHS number specified"""
     # Given
     nhs_number = NHSNumber(f"5{faker.random_int(max=999999999):09d}")
 

tests/unit/services/test_eligibility_services.py

@@ -20,7 +20,7 @@ def test_eligibility_service_returns_from_repo():
     assert actual == Eligibility(processed_suggestions=[])
 
 
-def test_eligibility_service_for_nonexistent_name():
+def test_eligibility_service_for_nonexistent_nhs_number():
     # Given
     eligibility_repo = MagicMock(spec=EligibilityRepo)
     eligibility_repo.get_eligibility_data = MagicMock(side_effect=NotFoundError)