Skip to content

Commit d3cfca2

Browse files
committed
(ELI-466) further clean up
1 parent dda5074 commit d3cfca2

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

.github/workflows/cicd-4-preprod-deploy.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,12 @@ jobs:
5454
shell: bash
5555
run: |
5656
set -euo pipefail
57-
# Mask the token in logs (defense in depth)
5857
echo "::add-mask::${GITHUB_TOKEN}"
59-
# Option 1: rewrite just 'origin' to tokenized HTTPS
6058
git remote set-url origin "https://x-access-token:${GITHUB_TOKEN}@github.com/${{ github.repository }}.git"
61-
# Sanity check (will fail if token is missing/insufficient)
6259
git ls-remote --tags origin >/dev/null
6360
6461
- name: Debug event
62+
if: env.ACT == 'true'
6563
run: |
6664
echo "GITHUB_EVENT_NAME=${GITHUB_EVENT_NAME}"
6765
echo "Payload:" && cat "$GITHUB_EVENT_PATH" || true

scripts/workflow/pre-release_resolver.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,13 @@
1717
import re
1818
import sys
1919
from dataclasses import dataclass
20-
from typing import List, Optional, NoReturn
20+
from typing import List, Optional
2121

2222
from ci_utils import (
2323
BRANCH,
2424
fail,
2525
ensure_token,
2626
fetch_latest_from_remote,
27-
gh_json,
2827
dev_tag_for_sha,
2928
sha_for_tag,
3029
is_ancestor,
@@ -85,8 +84,7 @@ def _run_gh(args: list[str]) -> str:
8584

8685
def list_successful_test_shas() -> List[str]:
8786
"""
88-
Return SHAs for successful runs of the PreProd deploy workflow on BRANCH.
89-
Uses `gh run list` with workflow **ID** for maximum CLI compatibility.
87+
Return SHAs for successful runs of the test deploy workflow on BRANCH.
9088
"""
9189
out = _run_gh([
9290
"run", "list",

0 commit comments

Comments
 (0)