Added global const for secret

Author: ayeshalshukri1-nhs

tests/integration/conftest.py

@@ -46,6 +46,8 @@
 
 AWS_REGION = "eu-west-1"
 
+AWS_CURRENT_SECRET = "test_value"
+AWS_PREVIOUS_SECRET = "test_value_old"
 
 @pytest.fixture(scope="session")
 def localstack(request: pytest.FixtureRequest) -> URL:
@@ -1045,7 +1047,7 @@ def campaign_config_with_missing_descriptions_missing_rule_text(
 
 # If you put StubSecretRepo in a separate module, import it instead
 class StubSecretRepo(SecretRepo):
-    def __init__(self, current: str = "test_value", previous: str = "test_value_old"):
+    def __init__(self, current: str = AWS_CURRENT_SECRET, previous: str = AWS_PREVIOUS_SECRET):
         self._current = current
         self._previous = previous
 
@@ -1059,8 +1061,8 @@ def get_secret_previous(self, secret_name: str) -> dict[str, str]:
 @pytest.fixture
 def hashing_service() -> HashingService:
     secret_repo = StubSecretRepo(
-        current="test_value",
-        previous="test_value_old",
+        current=AWS_CURRENT_SECRET,
+        previous=AWS_PREVIOUS_SECRET,
     )
 
     # The actual value of the name does not matter for the stub,

tests/integration/repo/test_person_repo.py

@@ -57,22 +57,24 @@ def test_items_found_but_person_attribute_type_not_found_raises_error(
         repo.get_eligibility_data(persisted_person_with_no_person_attribute_type)
 
 
-# def test_person_found_with_current_secret(person_table: Any,
-#                     persisted_person: NHSNumber,
-#                     hashing_service: HashingService,):
-#     # Given
-#     repo = PersonRepo(person_table, hashing_service)
-#
-#     # When
-#     actual = repo.get_eligibility_data(persisted_person)
-#
-#     # Then
-#     nhs_num_hash = hashing_service.hash_with_current_secret(persisted_person)
-#
-#     assert_that(
-#         actual.data,
-#         contains_inanyorder(
-#             has_entries({"NHS_NUMBER": nhs_num_hash, "ATTRIBUTE_TYPE": "PERSON"}),
-#             has_entries({"NHS_NUMBER": nhs_num_hash, "ATTRIBUTE_TYPE": "COHORTS"}),
-#         ),
-#     )
+def test_person_found_with_current_secret(person_table: Any,
+                    persisted_person: NHSNumber,
+                    hashing_service: HashingService):
+    # Given
+    repo = PersonRepo(person_table, hashing_service)
+
+    # When
+    actual = repo.get_eligibility_data(persisted_person)
+
+    # Then
+    nhs_num_hash = hashing_service.hash_with_current_secret(persisted_person)
+    nhs_num_hash_pre = hashing_service.hash_with_previous_secret(persisted_person)
+
+
+    assert_that(
+        actual.data,
+        contains_inanyorder(
+            has_entries({"NHS_NUMBER": nhs_num_hash, "ATTRIBUTE_TYPE": "PERSON"}),
+            has_entries({"NHS_NUMBER": nhs_num_hash, "ATTRIBUTE_TYPE": "COHORTS"}),
+        ),
+    )