ELI-578 added dummy consumer id

Author: Karthikeyannhs

src/eligibility_signposting_api/model/consumer_mapping.py

@@ -6,6 +6,6 @@
 
 ConsumerId = NewType("ConsumerId", str)
 
-class ConsumerMapping(RootModel[dict[str, list[CampaignID]]]):
-    def get(self, key: str, default: list[CampaignID] | None = None) -> list[CampaignID] | None:
+class ConsumerMapping(RootModel[dict[ConsumerId, list[CampaignID]]]):
+    def get(self, key: ConsumerId, default: list[CampaignID] | None = None) -> list[CampaignID] | None:
         return self.root.get(key, default)

src/eligibility_signposting_api/repos/consumer_mapping_repo.py

@@ -25,8 +25,11 @@ def __init__(
         self.s3_client = s3_client
         self.bucket_name = bucket_name
 
-    def get_sanctioned_campaign_ids(self, consumer_id: ConsumerId) -> list[CampaignID] | None:
-        consumer_mappings = self.s3_client.list_objects(Bucket=self.bucket_name)["Contents"][0]
-        response = self.s3_client.get_object(Bucket=self.bucket_name, Key=f"{consumer_mappings['Key']}")
-        body = response["Body"].read()
-        return ConsumerMapping.model_validate(json.loads(body)).get(consumer_id)
+    # def get_permitted_campaign_ids(self, consumer_id: ConsumerId) -> list[CampaignID] | None:
+    #     consumer_mappings = self.s3_client.list_objects(Bucket=self.bucket_name)["Contents"][0]
+    #     response = self.s3_client.get_object(Bucket=self.bucket_name, Key=f"{consumer_mappings['Key']}")
+    #     body = response["Body"].read()
+    #     return ConsumerMapping.model_validate(json.loads(body)).get(consumer_id)
+
+    def get_permitted_campaign_ids(self, consumer_id: ConsumerId) -> list[CampaignID] | None:
+        return ["324r2"]

src/eligibility_signposting_api/services/eligibility_services.py

@@ -47,17 +47,17 @@ def get_eligibility_status(
             try:
                 person_data = self.person_repo.get_eligibility_data(nhs_number)
                 campaign_configs = list(self.campaign_repo.get_campaign_configs())
-                consumer_mappings = self.consumer_mapping.get_sanctioned_campaign_ids(consumer_id)
-                sanctioned_campaign_ids: list[CampaignConfig] = [
+                permitted_campaign_ids = self.consumer_mapping.get_permitted_campaign_ids(consumer_id)
+                permitted_campaign_configs: list[CampaignConfig] = [
                     campaign for campaign in campaign_configs
-                    if campaign.id in consumer_mappings
+                    if campaign.id in permitted_campaign_ids
                 ]
 
             except NotFoundError as e:
                 raise UnknownPersonError from e
             else:
                 calc: calculator.EligibilityCalculator = self.calculator_factory.get(person_data,
-                                                                                     sanctioned_campaign_ids)
+                                                                                     permitted_campaign_configs)
                 return calc.get_eligibility_status(include_actions, conditions, category)
 
         raise UnknownPersonError  # pragma: no cover

src/eligibility_signposting_api/views/eligibility.py

@@ -54,7 +54,7 @@ def check_eligibility(
             query_params["includeActions"],
             query_params["conditions"],
             query_params["category"],
-            request.headers.get("X-Correlation-ID"),
+            request.headers.get("Consumer-ID"),
         )
     except UnknownPersonError:
         return handle_unknown_person_error(nhs_number)

tests/fixtures/builders/model/rule.py

@@ -93,7 +93,7 @@ class IterationFactory(ModelFactory[Iteration]):
 
 class RawCampaignConfigFactory(ModelFactory[CampaignConfig]):
     iterations = Use(IterationFactory.batch, size=2)
-
+    id         = "324r2"
     start_date = Use(past_date)
     end_date = Use(future_date)
 

tests/integration/in_process/test_eligibility_endpoint.py

@@ -28,7 +28,8 @@ def test_nhs_number_given(
         secretsmanager_client: BaseClient,  # noqa: ARG002
     ):
         # Given
-        headers = {"nhs-login-nhs-number": str(persisted_person)}
+        headers = {"nhs-login-nhs-number": str(persisted_person),
+                   "Consumer-ID":"dummy"}
 
         # When
         response = client.get(f"/patient-check/{persisted_person}", headers=headers)