eli 425 - handle value error in token replace (#327)

Co-authored-by: ayeshalshukri1-nhs <[email protected]>

Author: Karthikeyannhs

src/eligibility_signposting_api/services/processors/token_processor.py

@@ -118,9 +118,9 @@ def handle_token_not_found(parsed_token: ParsedToken, token: str) -> Never:
         raise ValueError(message)
 
     @staticmethod
-    def apply_formatting[T](attribute: dict[str, T], attribute_value: str, date_format: str | None) -> str:
+    def apply_formatting[T](attributes: dict[str, T], attribute_name: str, date_format: str | None) -> str:
         try:
-            attribute_data = attribute.get(attribute_value)
+            attribute_data = attributes.get(attribute_name)
             if (date_format or date_format == "") and attribute_data:
                 replace_with_date_object = datetime.strptime(str(attribute_data), "%Y%m%d").replace(tzinfo=UTC)
                 replace_with = replace_with_date_object.strftime(str(date_format))
@@ -130,3 +130,6 @@ def apply_formatting[T](attribute: dict[str, T], attribute_value: str, date_form
         except AttributeError as error:
             message = "Invalid token format"
             raise AttributeError(message) from error
+        except Exception as error:
+            message = "Invalid value error"
+            raise ValueError(message) from error

tests/unit/processor/__init__.py

@@ -0,0 +1,53 @@
+import pytest
+
+from eligibility_signposting_api.services.processors.token_processor import TokenProcessor
+
+
+@pytest.mark.parametrize(
+    ("date_format", "expected"),
+    [
+        (None, "20250510"),
+        ("%Y-%m-%d", "2025-05-10"),
+        ("%d/%m/%Y", "10/05/2025"),
+        ("%b %d, %Y", "May 10, 2025"),
+        ("%A, %d %B %Y", "Saturday, 10 May 2025"),
+        ("", ""),
+    ],
+)
+def test_apply_formatting_returns_valid_value(date_format, expected):
+    attribute = {"DATE_OF_BIRTH": "20250510"}
+    attribute_value = "DATE_OF_BIRTH"
+
+    actual = TokenProcessor.apply_formatting(attribute, attribute_value, date_format)
+    assert actual == expected
+
+
+def test_apply_formatting_attribute_not_present():
+    invalid_attribute = {"DATE_OF_BIRTH": "20250510"}
+    attribute_value = "ICE_CREAM"
+    date_format = None
+
+    actual = TokenProcessor.apply_formatting(invalid_attribute, attribute_value, date_format)
+
+    assert actual == ""
+
+
+def test_apply_formatting_raises_attribute_error():
+    invalid_attribute = "not_a_dict"
+    attribute_value = "DATE_OF_BIRTH"
+    date_format = None
+
+    with pytest.raises(AttributeError) as exc_info:
+        TokenProcessor.apply_formatting(invalid_attribute, attribute_value, date_format)
+
+    assert isinstance(exc_info.value, AttributeError)
+    assert str(exc_info.value) == "Invalid token format"
+
+
+def test_apply_formatting_raises_value_error_on_invalid_date():
+    attribute = {"DATE_OF_BIRTH": "invalid"}
+    attribute_value = "DATE_OF_BIRTH"
+    date_format = "%Y-%m-%d"
+
+    with pytest.raises(ValueError, match="Invalid value error$"):
+        TokenProcessor.apply_formatting(attribute, attribute_value, date_format)