ELI 442: fix - steps order correction in preprod deployment pipeline (#433)

* ELI 442: fix - steps order correction in preprod deployment pipeline

* ELI 442: fix - steps order correction in preprod deployment pipeline

* ELI 442: fix - steps order correction in preprod deployment pipeline

* ELI 442: correct env name

* ELI 442: lambda artifact management

Author: Karthikeyannhs

.github/workflows/base-deploy.yml

@@ -67,6 +67,7 @@ jobs:
           export TERRAFORM_VERSION="${{ steps.variables.outputs.terraform_version }}"
           export REF="${{ steps.variables.outputs.ref }}"
           export ENVIRONMENT="${{ steps.variables.outputs.environment }}"
+          export PROMOTED_ENVIRONMENT="${{ steps.variables.outputs.promoted_environment }}"
           echo "build_datetime=$BUILD_DATETIME"
           echo "build_timestamp=$BUILD_TIMESTAMP"
           echo "build_epoch=$BUILD_EPOCH"
@@ -75,6 +76,7 @@ jobs:
           echo "terraform_version=$TERRAFORM_VERSION"
           echo "ref=$REF"
           echo "environment=$ENVIRONMENT"
+          echo "promoted_environment=$PROMOTED_ENVIRONMENT"
 
       - name: "Resolve the dev-* tag for this commit"
         id: tag
@@ -117,12 +119,26 @@ jobs:
             ref: ${{ needs.metadata.outputs.ref }}
             fetch-depth: 0
 
+        - name: "Setup Terraform"
+          uses: hashicorp/setup-terraform@v3
+          with:
+            terraform_version: ${{ needs.metadata.outputs.terraform_version }}
+
         - name: "Configure AWS Credentials"
           uses: aws-actions/configure-aws-credentials@v5
           with:
             role-to-assume: arn:aws:iam::${{ secrets.AWS_ACCOUNT_ID }}:role/service-roles/github-actions-api-deployment-role
             aws-region: eu-west-2
 
+        - name: "Terraform Init"
+          env:
+            ENVIRONMENT: ${{ needs.metadata.outputs.promoted_environment }}
+            WORKSPACE: "default"
+          run: |
+            echo "Running: make terraform env=$ENVIRONMENT workspace=$WORKSPACE stack=api-layer tf-command=init"
+            make terraform env=$ENVIRONMENT stack=api-layer tf-command=init workspace=$WORKSPACE
+          working-directory: ./infrastructure
+
         - name: "Extract S3 bucket name from Terraform output"
           id: tf_output
           run: |
@@ -147,7 +163,7 @@ jobs:
   deploy:
     name: "Deploy to ${{ needs.metadata.outputs.environment }}"
     runs-on: ubuntu-latest
-    needs: [metadata]
+    needs: [metadata, download-lambda-artifact]
     timeout-minutes: 45
     permissions:
       id-token: write

DEPLOYMENT.md

@@ -26,6 +26,13 @@ Releases are immutable and auditable:
 
 > **Note:** The Preprod/prod entry workflows are thin wrappers around a **reusable** workflow (`base-deploy.yml`).
 
+### Lambda Artifact management
+
+1. `Dev deploy` → artifact is created and stored in GitHub actions.
+2. `Test deploy` → downloads the artifact from GitHub actions, uploads it to `Test` S3 and deploys to lambda.
+3. `Preprod deploy` → downloads the artifact from `Test` S3, uploads it to `Preprod` S3 and deploys to lambda.
+4. `Prod deploy` → downloads the artifact from `Preprod` s3, uploads it to `Prod` S3 and deploys to lambda.
+
 ---
 
 ## Pull Request Workflow (CI)