linting.

Author: ayeshalshukri1-nhs

tests/integration/conftest.py

@@ -411,15 +411,6 @@ def persisted_person_factory(
     hashing_service: HashingService,
     request: pytest.FixtureRequest,
 ):
-    """
-    Factory to persist a PERSON/COHORT record with different hashing strategies:
-      secret_key="current"  -> hash_with_current_secret
-      secret_key="previous" -> hash_with_previous_secret
-      secret_key="none"     -> store plain NHS number (no hash)
-
-    All created rows are automatically cleaned up.
-    """
-
     created_rows: list[dict[str, Any]] = []
 
     def _factory(
@@ -433,15 +424,15 @@ def _factory(
         nhs_num = faker.nhs_number()
         nhs_number = eligibility_status.NHSNumber(nhs_num)
 
-        # --- hashing selector ---
+        # hashing selector
         if secret_key == "current":  # noqa: S105
             nhs_key = hashing_service.hash_with_current_secret(nhs_num)
         elif secret_key == "previous":  # noqa: S105
             nhs_key = hashing_service.hash_with_previous_secret(nhs_num)
         elif secret_key == "not_hashed":  # noqa: S105
             nhs_key = nhs_num
 
-        # --- build DOB ---
+        # build DOB
         date_of_birth = eligibility_status.DateOfBirth(
             faker.date_of_birth(minimum_age=minimum_age, maximum_age=maximum_age)
         )
@@ -453,14 +444,14 @@ def _factory(
             cohorts=cohorts or ["cohort1"],
         ).data
 
-        # --- persist rows ---
+        # persist rows
         for row in rows:
             person_table.put_item(Item=row)
             created_rows.append(row)
 
         return nhs_number
 
-    # --- cleanup hook ---
+    # cleanup hook
     def cleanup():
         for row in created_rows:
             person_table.delete_item(

tests/integration/repo/test_person_repo.py

@@ -201,51 +201,41 @@ def test_get_person_record_returns_none_when_items_have_no_person_attribute_type
         # and record plain does not exist
         # then return record AWSCurrent with key AWSCurrent
         (True, False, "current", "current_record"),
-
         # If  key AWSCURRENT exists,      record AWSCurrent not exists,
         # and key AWSPREVIOUS not exists, record AWSPREVIOUS not exist,
         # and record plain does not exist
         # then person not found
         (True, False, None, "person_not_found"),
-
         # If  key AWSCURRENT exists,      record AWSCurrent not exists,
         # and key AWSPREVIOUS not exists, record AWSPREVIOUS not exist,
         # and record plain does exist
         # then return record plain
         (True, False, "not_hashed", "not_hashed_record"),
-
-
         # If  key AWSCURRENT not exists, record AWSCurrent not exists,
         # and key AWSPREVIOUS exists,    record AWSPREVIOUS exist,
         # and record plain does not exist
         # then return record AWSPrevious with key AWSPrevious
         (False, True, "previous", "previous_record"),
-
         # If  key AWSCURRENT not exists, record AWSCurrent not exists,
         # and key AWSPREVIOUS exists,    record AWSPREVIOUS not exist,
         # and record plain does not exist
         # then person not found
         (False, True, None, "person_not_found"),
-
         # If  key AWSCURRENT not exists, record AWSCurrent not exists,
         # and key AWSPREVIOUS exists,    record AWSPREVIOUS not exist,
         # and record plain does exist
         # then person not found
         (False, True, "not_hashed", "person_not_found"),
-
-
         # If  key AWSCURRENT not exists,  record AWSCurrent not exists,
         # and key AWSPREVIOUS not exists, record AWSPREVIOUS not exist,
         # and record plain does exist
         # then return record plain
         (False, False, "not_hashed", "not_hashed_record"),
-
         # If  key AWSCURRENT not exists,  record AWSCurrent not exists,
         # and key AWSPREVIOUS not exists, record AWSPREVIOUS not exist,
         # and record plain does not exist
         # then return person not found
         (False, False, None, "person_not_found"),
-
     ],
 )
 def test_secret_key_scenarios(  # noqa: PLR0913