Skip to content

Commit fe2a886

Browse files
ELI 546 -add more permissions in permission boundary
1 parent e5e35bc commit fe2a886

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

infrastructure/modules/secrets_manager/kms.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ resource "aws_kms_key" "secrets_cmk" {
1414
Sid = "AllowAccountAdminsFullAccess"
1515
Effect = "Allow"
1616
Principal = { AWS = "arn:aws:iam::${data.aws_caller_identity.current.account_id}:root" }
17-
actions = ["kms:*"]
18-
resources = ["*"]
17+
Action = "kms:*"
18+
Resource = "*"
1919
},
2020
# Allow Secrets Manager service to use the key
2121
{

infrastructure/modules/secrets_manager/secrets_manager.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ resource "aws_secretsmanager_secret" "hashing_secret" {
1313
# Initial secrets
1414
resource "aws_secretsmanager_secret_version" "hashing_secrets_test" {
1515
secret_id = aws_secretsmanager_secret.hashing_secret.id
16-
secret_string = "this_is_a_test_secret"
16+
secret_string = "initial_secret"
1717
}
1818

1919
# Resource-based policy attached to the secret

infrastructure/stacks/api-layer/assumed_role_permissions_boundary.tf

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,8 @@ data "aws_iam_policy_document" "assumed_role_permissions_boundary" {
5959
"xray:PutTelemetryRecords",
6060

6161
# Secret Manager
62-
"secretsmanager:GetSecretValue"
62+
"secretsmanager:GetSecretValue",
63+
"secretsmanager:DescribeSecret"
6364
]
6465

6566
resources = ["*"]

0 commit comments

Comments
 (0)