Fix: [AEA-5868] - fix for bots only replying to applicable threads (#205)

## Summary

**Remove items from this list if they are not relevant. Remove this line
once this has been done**

- Routine Change
- ❗ Breaking Change
- 🤖 Operational or Infrastructure Change
- ✨ New Feature
- ⚠️ Potential issues that might be caused by this change

### Details

Add any summary information of what is in the change. **Remove this line
if you have nothing to add.**

## Pull Request Naming

Pull requests should be named using the following format:

```text
Tag: [AEA-NNNN] - Short description
```

Tag can be one of:

- `Fix` - for a bug fix. (Patch release)
- `Update` - either for a backwards-compatible enhancement or for a rule
change that adds reported problems. (Patch release)
- `New` - implemented a new feature. (Minor release)
- `Breaking` - for a backwards-incompatible enhancement or feature.
(Major release)
- `Docs` - changes to documentation only. (Patch release)
- `Build` - changes to build process only. (No release)
- `Upgrade` - for a dependency upgrade. (Patch release)
- `Chore` - for refactoring, adding tests, etc. (anything that isn't
user-facing). (Patch release)

If the current release is x.y.z then
- a patch release increases z by 1
- a minor release increases y by 1
- a major release increases x by 1

Correct tagging is necessary for our automated versioning and release
process.

The description of your pull request will be used as the commit message
for the merge, and also be included in the changelog. Please ensure that
your title is sufficiently descriptive.

### Rerunning Checks

If you need to rename your pull request, you can restart the checks by
either:

- Closing and reopening the pull request
- pushing an empty commit 
  ```bash
  git commit --allow-empty -m 'trigger build'
  git push
  ```
- Amend your last commit and force push to the branch
  ```bash
  git commit --amend --no-edit
  git push --force
  ```

Rerunning the checks from within the pull request will not use the
updated title.

Author: bencegadanyi1-nhs

packages/slackBotFunction/app/utils/handler_utils.py

@@ -292,15 +292,15 @@ def should_reply_to_message(event: Dict[str, Any], client: WebClient = None) ->
     Conditions:
     should not reply if:
     - Message is in a group chat (channel_type == 'group') but not in a thread
-    - Message is in a channel thread where the bot was not initially mentioned
+    - Message is in a channel or group thread where the bot was not initially mentioned
     """
 
     # we don't reply to non-threaded messages in group chats
     if event.get("channel_type") == "group" and event.get("type") == "message" and event.get("thread_ts") is None:
         return False
 
-    # for channel threads, check if bot was mentioned anywhere in the thread history
-    if event.get("channel_type") == "channel" and event.get("thread_ts"):
+    # for channel or group threads, check if bot was mentioned anywhere in the thread history
+    if event.get("channel_type") in ["channel", "group"] and event.get("thread_ts"):
         if not client:
             logger.warning("No Slack client provided to check thread participation")
             return True

packages/slackBotFunction/tests/test_handler_utils.py

@@ -527,6 +527,44 @@ def test_was_bot_mentioned_later_in_thread(mock_env: Mock):
     assert result is True
 
 
+def test_should_reply_to_message_group_thread_with_bot_mention(mock_env: Mock):
+    """test should_reply_to_message returns True for group thread where bot was mentioned"""
+    mock_client = Mock()
+    mock_client.auth_test.return_value = {"ok": True, "user_id": "U123"}
+    mock_client.conversations_replies.return_value = {
+        "ok": True,
+        "messages": [{"text": "<@U123> help me", "ts": "1234567890.123456"}],
+    }
+
+    if "app.utils.handler_utils" in sys.modules:
+        del sys.modules["app.utils.handler_utils"]
+    from app.utils.handler_utils import should_reply_to_message
+
+    event = {"channel_type": "group", "type": "message", "channel": "G123", "thread_ts": "1234567890.123456"}
+    result = should_reply_to_message(event, mock_client)
+
+    assert result is True
+
+
+def test_should_reply_to_message_group_thread_without_bot_mention(mock_env: Mock):
+    """test should_reply_to_message returns False for group thread where bot was not mentioned"""
+    mock_client = Mock()
+    mock_client.auth_test.return_value = {"ok": True, "user_id": "U123"}
+    mock_client.conversations_replies.return_value = {
+        "ok": True,
+        "messages": [{"text": "some discussion", "ts": "1234567890.123456"}],
+    }
+
+    if "app.utils.handler_utils" in sys.modules:
+        del sys.modules["app.utils.handler_utils"]
+    from app.utils.handler_utils import should_reply_to_message
+
+    event = {"channel_type": "group", "type": "message", "channel": "G123", "thread_ts": "1234567890.123456"}
+    result = should_reply_to_message(event, mock_client)
+
+    assert result is False
+
+
 def test_get_bot_user_id_auth_test_fails(mock_env: Mock):
     """test get_bot_user_id returns None when auth_test fails"""
     mock_client = Mock()