Skip to content

Commit 1b1aab3

Browse files
committed
Remove unused accessLogBucket
1 parent 344906d commit 1b1aab3

File tree

3 files changed

+4
-39
lines changed

3 files changed

+4
-39
lines changed

packages/cdk/bin/EpsAssistMeApp.ts

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -41,18 +41,6 @@ const EpsAssistMe = new EpsAssistMeStack(app, "EpsAssistMeStack", {
4141
// Run a synth to add cross region lambdas and roles
4242
app.synth()
4343

44-
// S3 Bucket: StorageAccessLogsBucketAccessLogs86FA3BBC
45-
// CDK-Path: EpsAssistMeStack/Storage/AccessLogsBucket/AccessLogs/Resource
46-
addCfnGuardMetadata(EpsAssistMe, "Storage/AccessLogsBucket", "AccessLogs",
47-
["S3_BUCKET_REPLICATION_ENABLED", "S3_BUCKET_VERSIONING_ENABLED", "S3_BUCKET_LOGGING_ENABLED"]
48-
)
49-
50-
// S3 Bucket Policy: StorageAccessLogsBucketAccessLogsPolicy523966CD
51-
// CDK-Path: EpsAssistMeStack/Storage/AccessLogsBucket/AccessLogs/Policy/Resource
52-
addCfnGuardMetadata(EpsAssistMe, "Storage/AccessLogsBucket/AccessLogs", "Policy",
53-
["S3_BUCKET_SSL_REQUESTS_ONLY"]
54-
)
55-
5644
// S3 Bucket: StorageDocsBucketDocs0C9A9D9E
5745
// CDK-Path: EpsAssistMeStack/Storage/DocsBucket/Docs/Resource
5846
addCfnGuardMetadata(EpsAssistMe, "Storage/DocsBucket", "Docs",
@@ -65,18 +53,6 @@ addCfnGuardMetadata(EpsAssistMe, "Storage/DocsBucket/Docs", "Policy",
6553
["S3_BUCKET_SSL_REQUESTS_ONLY"]
6654
)
6755

68-
// S3 Bucket: StorageLoggingBucketLogging36F28A73
69-
// CDK-Path: EpsAssistMeStack/Storage/LoggingBucket/Logging/Resource
70-
addCfnGuardMetadata(EpsAssistMe, "Storage/LoggingBucket", "Logging",
71-
["S3_BUCKET_REPLICATION_ENABLED", "S3_BUCKET_LOGGING_ENABLED"]
72-
)
73-
74-
// S3 Bucket Policy: StorageLoggingBucketLoggingPolicy06AD29F1
75-
// CDK-Path: EpsAssistMeStack/Storage/LoggingBucket/Logging/Policy/Resource
76-
addCfnGuardMetadata(EpsAssistMe, "Storage/LoggingBucket/Logging", "Policy",
77-
["S3_BUCKET_SSL_REQUESTS_ONLY"]
78-
)
79-
8056
// Lambda Function: CustomS3AutoDeleteObjectsCustomResourceProviderHandler9D90184F
8157
// CDK-Path: EpsAssistMeStack/Custom::S3AutoDeleteObjectsCustomResourceProvider/Handler
8258
addCfnGuardMetadata(EpsAssistMe, "Custom::S3AutoDeleteObjectsCustomResourceProvider", "Handler",

packages/cdk/constructs/S3Bucket.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@ import {Key} from "aws-cdk-lib/aws-kms"
1010

1111
export interface S3BucketProps {
1212
bucketName: string
13-
kmsKey?: Key
14-
accessLogsBucket?: Bucket
15-
versioned?: boolean
13+
kmsKey: Key
14+
versioned: boolean
1615
}
1716

1817
export class S3Bucket extends Construct {
@@ -30,9 +29,7 @@ export class S3Bucket extends Construct {
3029
autoDeleteObjects: true,
3130
enforceSSL: true,
3231
versioned: props.versioned ?? false,
33-
objectOwnership: ObjectOwnership.BUCKET_OWNER_ENFORCED,
34-
serverAccessLogsBucket: props.accessLogsBucket,
35-
serverAccessLogsPrefix: props.accessLogsBucket ? "s3-access-logs/" : undefined
32+
objectOwnership: ObjectOwnership.BUCKET_OWNER_ENFORCED
3633
})
3734

3835
this.kmsKey = props.kmsKey

packages/cdk/resources/Storage.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,29 +4,21 @@ import {S3Bucket} from "../constructs/S3Bucket"
44

55
export class Storage extends Construct {
66
public readonly kbDocsBucket: S3Bucket
7-
public readonly accessLogBucket: S3Bucket
87
public readonly kbDocsKey: Key
98

109
constructor(scope: Construct, id: string) {
1110
super(scope, id)
1211

13-
// Create S3 bucket for storing API Gateway and S3 access logs
14-
this.accessLogBucket = new S3Bucket(this, "AccessLogsBucket", {
15-
bucketName: "AccessLogs",
16-
versioned: false
17-
})
18-
1912
// Create customer-managed KMS key for knowledge base document encryption
2013
this.kbDocsKey = new Key(this, "KbDocsKey", {
2114
enableKeyRotation: true,
2215
description: "KMS key for encrypting knowledge base documents"
2316
})
2417

25-
// Create S3 bucket for knowledge base documents with encryption and access logging
18+
// Create S3 bucket for knowledge base documents with encryption
2619
this.kbDocsBucket = new S3Bucket(this, "DocsBucket", {
2720
bucketName: "Docs",
2821
kmsKey: this.kbDocsKey,
29-
accessLogsBucket: this.accessLogBucket.bucket,
3022
versioned: true
3123
})
3224
}

0 commit comments

Comments
 (0)