better error logging

Author: anthony-nhs

packages/slackBotFunction/app/core/config.py

@@ -5,6 +5,7 @@
 
 import os
 import json
+import traceback
 import boto3
 from slack_bolt import App
 from aws_lambda_powertools import Logger
@@ -40,8 +41,8 @@
 
 except json.JSONDecodeError as e:
     raise ValueError(f"Invalid JSON in Parameter Store: {e}")
-except Exception as e:
-    logger.error("Configuration error", extra={"error": str(e)})
+except Exception:
+    logger.error("Configuration error", extra={"error": traceback.format_exc()})
     raise
 
 # initialise the Slack app

packages/slackBotFunction/app/services/prompt_loader.py

@@ -1,4 +1,5 @@
 import os
+import traceback
 import boto3
 from botocore.exceptions import ClientError
 from app.services.exceptions import PromptNotFoundError, PromptLoadError
@@ -52,7 +53,12 @@ def load_prompt(logger, prompt_name: str, prompt_version: str = None) -> str:
 
         logger.error(
             f"Failed to load prompt '{prompt_name}' version '{prompt_version}': {error_code} - {error_message}",
-            extra={"prompt_name": prompt_name, "error_code": error_code, "requested_version": prompt_version},
+            extra={
+                "prompt_name": prompt_name,
+                "error_code": error_code,
+                "requested_version": prompt_version,
+                "error": traceback.format_exc(),
+            },
         )
         raise PromptLoadError(
             f"Failed to load prompt '{prompt_name}' version '{prompt_version}': {error_code} - {error_message}"
@@ -61,7 +67,7 @@ def load_prompt(logger, prompt_name: str, prompt_version: str = None) -> str:
     except Exception as e:
         logger.error(
             "Unexpected error loading prompt",
-            extra={"prompt_name": prompt_name, "error": str(e), "error_type": type(e).__name__},
+            extra={"prompt_name": prompt_name, "error_type": type(e).__name__, "error": traceback.format_exc()},
         )
         raise PromptLoadError(f"Unexpected error loading prompt '{prompt_name}': {e}")
 
@@ -82,6 +88,6 @@ def get_prompt_id_from_name(logger, client, prompt_name: str) -> str | None:
         logger.error("No prompt found with name", extra={"prompt_name": prompt_name})
         return None
 
-    except ClientError as e:
-        logger.error("Failed to list prompts", extra={"error": str(e)})
+    except ClientError:
+        logger.error("Failed to list prompts", extra={"error": traceback.format_exc()})
         return None

packages/slackBotFunction/app/services/query_reformulator.py

@@ -1,5 +1,6 @@
 import os
 import json
+import traceback
 import boto3
 from .prompt_loader import load_prompt
 from .exceptions import ConfigurationError
@@ -71,6 +72,7 @@ def reformulate_query(logger, user_query: str) -> str:
                 "prompt_name": os.environ.get("QUERY_REFORMULATION_PROMPT_NAME"),
                 "prompt_version": os.environ.get("QUERY_REFORMULATION_PROMPT_VERSION", "auto"),
                 "error_type": type(e).__name__,
+                "error": traceback.format_exc(),
             },
         )
 

packages/slackBotFunction/app/slack/slack_events.py

@@ -5,6 +5,7 @@
 
 import re
 import time
+import traceback
 import boto3
 from slack_sdk import WebClient
 from app.core.config import (
@@ -86,8 +87,8 @@ def process_async_slack_event(slack_event_data):
             )
         client.chat_postMessage(channel=channel, text=response_text, thread_ts=thread_ts)
 
-    except Exception as err:
-        logger.error("Error processing message", extra={"event_id": event_id, "error": str(err)})
+    except Exception:
+        logger.error("Error processing message", extra={"event_id": event_id, "error": traceback.format_exc()})
 
         # incase Slack API call fails, we still want to log the error
         try:
@@ -96,8 +97,8 @@ def process_async_slack_event(slack_event_data):
                 text=BOT_MESSAGES["error_response"],
                 thread_ts=thread_ts,
             )
-        except Exception as post_err:
-            logger.error("Failed to post error message", extra={"error": str(post_err)})
+        except Exception:
+            logger.error("Failed to post error message", extra={"error": traceback.format_exc()})
 
 
 def get_conversation_session(conversation_key):
@@ -110,8 +111,8 @@ def get_conversation_session(conversation_key):
             logger.info("Found existing session", extra={"conversation_key": conversation_key})
             return response["Item"]["session_id"]
         return None
-    except Exception as e:
-        logger.error("Error getting session", extra={"error": str(e)})
+    except Exception:
+        logger.error("Error getting session", extra={"error": traceback.format_exc()})
         return None
 
 
@@ -134,8 +135,8 @@ def store_conversation_session(conversation_key, session_id, user_id, channel_id
             }
         )
         logger.info("Stored session", extra={"session_id": session_id, "conversation_key": conversation_key})
-    except Exception as e:
-        logger.error("Error storing session", extra={"error": str(e)})
+    except Exception:
+        logger.error("Error storing session", extra={"error": traceback.format_exc()})
 
 
 def query_bedrock(user_query, session_id=None):

packages/slackBotFunction/app/slack/slack_handlers.py

@@ -4,6 +4,7 @@
 
 import time
 import json
+import traceback
 import boto3
 from botocore.exceptions import ClientError
 from app.core.config import table, bot_token, logger
@@ -78,7 +79,7 @@ def is_duplicate_event(event_id):
     except ClientError as e:
         if e.response["Error"]["Code"] == "ConditionalCheckFailedException":
             return True  # Duplicate
-        logger.error("Error checking event duplication", extra={"error": str(e)})
+        logger.error("Error checking event duplication", extra={"error": traceback.format_exc()})
         return False
 
 
@@ -99,5 +100,5 @@ def trigger_async_processing(event_data):
             Payload=json.dumps({"async_processing": True, "slack_event": event_data}),
         )
         logger.info("Async processing triggered successfully")
-    except Exception as e:
-        logger.error("Failed to trigger async processing", extra={"error": str(e)})
+    except Exception:
+        logger.error("Failed to trigger async processing", extra={"error": traceback.format_exc()})

packages/syncKnowledgeBaseFunction/app/handler.py

@@ -7,6 +7,7 @@
 """
 
 import time
+import traceback
 import boto3
 from botocore.exceptions import ClientError
 from app.config.config import KNOWLEDGEBASE_ID, DATA_SOURCE_ID, SUPPORTED_FILE_TYPES, logger
@@ -259,6 +260,7 @@ def handler(event, context):
                 "error_type": type(e).__name__,
                 "error_message": str(e),
                 "duration_ms": round((time.time() - start_time) * 1000, 2),
+                "error": traceback.format_exc(),
             },
         )
         return {"statusCode": 500, "body": f"Unexpected error: {str(e)}"}