Merge branch 'main' of https://github.com/NHSDigital/eps-assist-me into AEA-5507-code-tidy-up

Author: kris-szlapa

.devcontainer/Dockerfile

@@ -24,6 +24,8 @@ ENV PATH="$PATH:/home/vscode/.asdf/bin/:/workspaces/eps-assist-me/node_modules/.
 # Install ASDF plugins
 RUN asdf plugin add python; \
     asdf plugin add poetry https://github.com/asdf-community/asdf-poetry.git; \
+    asdf plugin add shellcheck https://github.com/luizm/asdf-shellcheck.git; \
+    asdf plugin add nodejs https://github.com/asdf-vm/asdf-nodejs.git; \
     asdf plugin add direnv; \
     asdf plugin add actionlint; \
     asdf plugin add ruby https://github.com/asdf-vm/asdf-ruby.git
@@ -32,7 +34,7 @@ RUN asdf plugin add python; \
 WORKDIR /workspaces/eps-assist-me
 
 # Copy .tool-versions
-ADD .tool-versions /workspaces/prescriptionsforpatients/.tool-versions
+ADD .tool-versions /workspaces/eps-assist-me/.tool-versions
 ADD .tool-versions /home/vscode/.tool-versions
 
 # Install tools

.tool-versions

@@ -1,3 +1,4 @@
+nodejs 22.12.0
 python 3.12.7
 poetry 1.8.3
 shellcheck 0.10.0

Makefile

@@ -6,14 +6,17 @@ guard-%:
 
 .PHONY: install build test publish release clean
 
-install: install-python install-hooks
+install: install-python install-hooks install-node
 
 install-python:
 	poetry install
 
 install-hooks: install-python
 	poetry run pre-commit install --install-hooks --overwrite
 
+install-node:
+	npm ci
+
 pre-commit: git-secrets-docker-setup
 	poetry run pre-commit run --all-files
 

README.md

@@ -42,6 +42,36 @@ This will ensure that your VSCode bash terminal prompts you for your GPG key pas
 
 You can cache the gpg key passphrase by following instructions at https://superuser.com/questions/624343/keep-gnupg-credentials-cached-for-entire-user-session
 
+### Setup
+
+Ensure you have the following lines in the file .envrc
+
+```bash
+export AWS_DEFAULT_PROFILE=prescription-dev
+```
+
+Once you have saved .envrc, start a new terminal in vscode and run this command to authenticate against AWS
+
+```bash
+make aws-configure
+```
+
+Put the following values in:
+
+```text
+SSO session name (Recommended): sso-session
+SSO start URL [None]: <USE VALUE OF SSO START URL FROM AWS LOGIN COMMAND LINE ACCESS INSTRUCTIONS ACCESSED FROM https://myapps.microsoft.com>
+SSO region [None]: eu-west-2
+SSO registration scopes [sso:account:access]:
+```
+
+This will then open a browser window and you should authenticate with your hscic credentials
+You should then select the development account and set default region to be eu-west-2.
+
+You will now be able to use AWS and SAM CLI commands to access the dev account. You can also use the AWS extension to view resources.
+
+When the token expires, you may need to reauthorise using `make aws-login`
+
 ### CI Setup
 
 The GitHub Actions require a secret to exist on the repo called "SONAR_TOKEN".