Skip to content

Commit 4054bbb

Browse files
feat: Add orchestration prompt
1 parent 99dbb8e commit 4054bbb

File tree

3 files changed

+13
-10
lines changed

3 files changed

+13
-10
lines changed

packages/slackBotFunction/app/services/bedrock.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ def query_bedrock(user_query: str, session_id: str = None) -> RetrieveAndGenerat
2121
"""
2222

2323
config = get_retrieve_generate_config()
24-
generation_template = load_prompt(config.RAG_GENERATION_PROMPT_NAME, config.RAG_GENERATION_PROMPT_VERSION)
24+
generation_template = load_prompt(config.RAG_RESPONSE_PROMPT_NAME, config.RAG_RESPONSE_PROMPT_VERSION)
2525
orchestration_template = load_prompt(config.RAG_ORCHESTRATION_PROMPT_NAME, config.RAG_ORCHESTRATION_PROMPT_VERSION)
2626
inference_config = generation_template.get("inference_config")
2727

@@ -30,7 +30,7 @@ def query_bedrock(user_query: str, session_id: str = None) -> RetrieveAndGenerat
3030
inference_config = default_values
3131
logger.warning(
3232
"No inference configuration found in prompt template; using default values",
33-
extra={"prompt_name": config.RAG_GENERATION_PROMPT_NAME, "default_inference_config": default_values},
33+
extra={"prompt_name": config.RAG_RESPONSE_PROMPT_NAME, "default_inference_config": default_values},
3434
)
3535

3636
client: AgentsforBedrockRuntimeClient = boto3.client(
@@ -42,7 +42,7 @@ def query_bedrock(user_query: str, session_id: str = None) -> RetrieveAndGenerat
4242
logger.error(
4343
"Prompt templates for RAG generation or orchestration not found",
4444
extra={
45-
"generation_prompt_name": config.RAG_GENERATION_PROMPT_NAME,
45+
"generation_prompt_name": config.RAG_RESPONSE_PROMPT_NAME,
4646
"orchestration_prompt_name": config.RAG_ORCHESTRATION_PROMPT_NAME,
4747
},
4848
)
@@ -90,7 +90,7 @@ def query_bedrock(user_query: str, session_id: str = None) -> RetrieveAndGenerat
9090

9191
logger.info(
9292
"Using prompt template for RAG response generation",
93-
extra={"prompt_name": config.RAG_GENERATION_PROMPT_NAME},
93+
extra={"prompt_name": config.RAG_RESPONSE_PROMPT_NAME},
9494
)
9595

9696
# Include session ID for conversation continuity across messages

packages/slackBotFunction/tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def mock_env():
2626
"QUERY_REFORMULATION_PROMPT_VERSION": "DRAFT",
2727
"RAG_RESPONSE_PROMPT_NAME": "test-rag-prompt",
2828
"RAG_RESPONSE_PROMPT_VERSION": "DRAFT",
29-
"RAG_ORCHESTRATION_PROMPT_NAME": "test-rag-prompt",
29+
"RAG_ORCHESTRATION_PROMPT_NAME": "test-orc-prompt",
3030
"RAG_ORCHESTRATION_PROMPT_VERSION": "DRAFT",
3131
}
3232
env_vars["AWS_DEFAULT_REGION"] = env_vars["AWS_REGION"]

packages/slackBotFunction/tests/test_bedrock_integration.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import sys
2+
from unittest import mock
23
from unittest.mock import Mock, patch
34

45

@@ -20,8 +21,13 @@ def test_get_bedrock_knowledgebase_response(mock_boto_client: Mock, mock_load_pr
2021
result = query_bedrock("test query")
2122

2223
# assertions
23-
mock_load_prompt.assert_called_once_with("test-rag-prompt", "DRAFT")
24-
mock_boto_client.assert_called_once_with(service_name="bedrock-agent-runtime", region_name="eu-west-2")
24+
mock_load_prompt.assert_has_calls(
25+
[
26+
mock.call("test-rag-prompt", "DRAFT"),
27+
mock.call("test-orc-prompt", "DRAFT"),
28+
]
29+
)
30+
mock_boto_client.assert_called_with(service_name="bedrock-agent-runtime", region_name="eu-west-2")
2531
mock_client.retrieve_and_generate.assert_called_once()
2632
assert result["output"]["text"] == "bedrock response"
2733

@@ -45,7 +51,6 @@ def test_query_bedrock_with_session(mock_boto_client: Mock, mock_load_prompt: Mo
4551
result = query_bedrock("test query", session_id="existing_session")
4652

4753
# assertions
48-
mock_load_prompt.assert_called_once_with("test-rag-prompt", "DRAFT")
4954
assert result == mock_response
5055
call_args = mock_client.retrieve_and_generate.call_args[1]
5156
assert call_args["sessionId"] == "existing_session"
@@ -70,7 +75,6 @@ def test_query_bedrock_without_session(mock_boto_client: Mock, mock_load_prompt:
7075
result = query_bedrock("test query")
7176

7277
# assertions
73-
mock_load_prompt.assert_called_once_with("test-rag-prompt", "DRAFT")
7478
assert result == mock_response
7579
call_args = mock_client.retrieve_and_generate.call_args[1]
7680
assert "sessionId" not in call_args
@@ -95,7 +99,6 @@ def test_query_bedrock_check_prompt(mock_boto_client: Mock, mock_load_prompt: Mo
9599
result = query_bedrock("test query")
96100

97101
# assertions
98-
mock_load_prompt.assert_called_once_with("test-rag-prompt", "DRAFT")
99102
call_args = mock_client.retrieve_and_generate.call_args[1]
100103
prompt_template = call_args["retrieveAndGenerateConfiguration"]["knowledgeBaseConfiguration"][
101104
"generationConfiguration"

0 commit comments

Comments
 (0)