test: test cases for new methods

Author: bencegadanyi1-nhs

packages/slackBotFunction/tests/test_handler_utils.py

@@ -359,3 +359,169 @@ def test_extract_pull_request_id_extracts_when_there_is_a_mention():
     # assertions
     assert pr_id == "12345"
     assert text == "<@U123> some question"
+
+
+def test_was_bot_mentioned_in_thread_root_with_mention(mock_env: Mock):
+    """test that was_bot_mentioned_in_thread_root returns true when this bot is mentioned"""
+    mock_client = Mock()
+    mock_client.auth_test.return_value = {"ok": True, "user_id": "U123ABC"}
+    mock_client.conversations_replies.return_value = {
+        "ok": True,
+        "messages": [{"text": "<@U123ABC> hello bot", "ts": "1234567890.123456"}],
+    }
+
+    if "app.utils.handler_utils" in sys.modules:
+        del sys.modules["app.utils.handler_utils"]
+    from app.utils.handler_utils import was_bot_mentioned_in_thread_root
+
+    result = was_bot_mentioned_in_thread_root("C123", "1234567890.123456", mock_client)
+
+    assert result is True
+    mock_client.conversations_replies.assert_called_once_with(channel="C123", ts="1234567890.123456", inclusive=True)
+
+
+def test_was_bot_mentioned_in_thread_root_without_mention(mock_env: Mock):
+    """test that was_bot_mentioned_in_thread_root returns false when bot is not mentioned"""
+    mock_client = Mock()
+    mock_client.auth_test.return_value = {"ok": True, "user_id": "U123ABC"}
+    mock_client.conversations_replies.return_value = {
+        "ok": True,
+        "messages": [{"text": "hello everyone", "ts": "1234567890.123456"}],
+    }
+
+    if "app.utils.handler_utils" in sys.modules:
+        del sys.modules["app.utils.handler_utils"]
+    from app.utils.handler_utils import was_bot_mentioned_in_thread_root
+
+    result = was_bot_mentioned_in_thread_root("C123", "1234567890.123456", mock_client)
+
+    assert result is False
+
+
+def test_was_bot_mentioned_in_thread_root_exception(mock_env: Mock):
+    """tes that was_bot_mentioned_in_thread_root fails open on exception"""
+    mock_client = Mock()
+    mock_client.conversations_replies.side_effect = Exception("API Error")
+
+    if "app.utils.handler_utils" in sys.modules:
+        del sys.modules["app.utils.handler_utils"]
+    from app.utils.handler_utils import was_bot_mentioned_in_thread_root
+
+    result = was_bot_mentioned_in_thread_root("C123", "1234567890.123456", mock_client)
+
+    assert result is True
+
+
+def test_should_reply_to_message_dm(mock_env: Mock):
+    """test should_reply_to_message returns True for DMs"""
+    if "app.utils.handler_utils" in sys.modules:
+        del sys.modules["app.utils.handler_utils"]
+    from app.utils.handler_utils import should_reply_to_message
+
+    event = {"channel_type": "im", "type": "message", "channel": "D123", "ts": "123"}
+    result = should_reply_to_message(event)
+
+    assert result is True
+
+
+def test_should_reply_to_message_group_without_thread(mock_env: Mock):
+    """test should_reply_to_message returns False for group messages without thread"""
+    if "app.utils.handler_utils" in sys.modules:
+        del sys.modules["app.utils.handler_utils"]
+    from app.utils.handler_utils import should_reply_to_message
+
+    event = {"channel_type": "group", "type": "message", "channel": "G123", "ts": "123"}
+    result = should_reply_to_message(event)
+
+    assert result is False
+
+
+def test_should_reply_to_message_channel_thread_with_bot_mention(mock_env: Mock):
+    """test should_reply_to_message returns True for channel thread where bot was mentioned"""
+    mock_client = Mock()
+    mock_client.auth_test.return_value = {"ok": True, "user_id": "U123"}
+    mock_client.conversations_replies.return_value = {
+        "ok": True,
+        "messages": [{"text": "<@U123> help me", "ts": "1234567890.123456"}],
+    }
+
+    if "app.utils.handler_utils" in sys.modules:
+        del sys.modules["app.utils.handler_utils"]
+    from app.utils.handler_utils import should_reply_to_message
+
+    event = {"channel_type": "channel", "type": "message", "channel": "C123", "thread_ts": "1234567890.123456"}
+    result = should_reply_to_message(event, mock_client)
+
+    assert result is True
+
+
+def test_should_reply_to_message_channel_thread_without_bot_mention(mock_env: Mock):
+    """test should_reply_to_message returns False for channel thread where bot was not mentioned"""
+    mock_client = Mock()
+    mock_client.auth_test.return_value = {"ok": True, "user_id": "U123"}
+    mock_client.conversations_replies.return_value = {
+        "ok": True,
+        "messages": [{"text": "some discussion", "ts": "1234567890.123456"}],
+    }
+
+    if "app.utils.handler_utils" in sys.modules:
+        del sys.modules["app.utils.handler_utils"]
+    from app.utils.handler_utils import should_reply_to_message
+
+    event = {"channel_type": "channel", "type": "message", "channel": "C123", "thread_ts": "1234567890.123456"}
+    result = should_reply_to_message(event, mock_client)
+
+    assert result is False
+
+
+def test_should_reply_to_message_channel_thread_no_client(mock_env: Mock):
+    """test should_reply_to_message fails open when no client provided"""
+    # setup mocks
+    if "app.utils.handler_utils" in sys.modules:
+        del sys.modules["app.utils.handler_utils"]
+    from app.utils.handler_utils import should_reply_to_message
+
+    event = {"channel_type": "channel", "type": "message", "channel": "C123", "thread_ts": "1234567890.123456"}
+    result = should_reply_to_message(event, None)
+
+    assert result is True
+
+
+def test_was_bot_mentioned_in_thread_different_bot(mock_env: Mock):
+    """test that was_bot_mentioned_in_thread_root returns false when a different bot is mentioned"""
+    mock_client = Mock()
+    mock_client.auth_test.return_value = {"ok": True, "user_id": "U123ABC"}
+    mock_client.conversations_replies.return_value = {
+        "ok": True,
+        "messages": [{"text": "<@U999XYZ> hello other bot", "ts": "1234567890.123456"}],  # Different bot
+    }
+
+    if "app.utils.handler_utils" in sys.modules:
+        del sys.modules["app.utils.handler_utils"]
+    from app.utils.handler_utils import was_bot_mentioned_in_thread_root
+
+    result = was_bot_mentioned_in_thread_root("C123", "1234567890.123456", mock_client)
+
+    assert result is False
+
+
+def test_was_bot_mentioned_later_in_thread(mock_env: Mock):
+    """test that bot mention later in thread is detected"""
+    mock_client = Mock()
+    mock_client.auth_test.return_value = {"ok": True, "user_id": "U123ABC"}
+    mock_client.conversations_replies.return_value = {
+        "ok": True,
+        "messages": [
+            {"text": "Starting a discussion", "ts": "1234567890.123456"},
+            {"text": "Some reply", "ts": "1234567890.123457"},
+            {"text": "<@U123ABC> can you help with this?", "ts": "1234567890.123458"},  # Bot mentioned later
+        ],
+    }
+
+    if "app.utils.handler_utils" in sys.modules:
+        del sys.modules["app.utils.handler_utils"]
+    from app.utils.handler_utils import was_bot_mentioned_in_thread_root
+
+    result = was_bot_mentioned_in_thread_root("C123", "1234567890.123456", mock_client)
+
+    assert result is True