Skip to content

Commit 92036d3

Browse files
committed
Set stack name to pull request number
1 parent dd82f53 commit 92036d3

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

.github/workflows/pull_request.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,15 +56,15 @@ jobs:
5656
needs: [get_issue_number, get_commit_id]
5757
uses: ./.github/workflows/cdk_package_code.yml
5858
with:
59-
STACK_NAME: epsam
59+
STACK_NAME: epsam-pr-${{needs.get_issue_number.outputs.issue_number}}
6060
VERSION_NUMBER: PR-${{ needs.get_issue_number.outputs.issue_number }}
6161
COMMIT_ID: ${{ needs.get_commit_id.outputs.commit_id }}
6262

6363
release_code:
6464
needs: [get_issue_number, package_code, get_commit_id]
6565
uses: ./.github/workflows/cdk_release_code.yml
6666
with:
67-
STACK_NAME: epsam
67+
STACK_NAME: epsam-pr-${{needs.get_issue_number.outputs.issue_number}}
6868
TARGET_ENVIRONMENT: dev-pr
6969
VERSION_NUMBER: PR-${{ needs.get_issue_number.outputs.issue_number }}
7070
COMMIT_ID: ${{ needs.get_commit_id.outputs.commit_id }}

packages/cdk/resources/Secrets.ts

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@ import {Secret} from "aws-cdk-lib/aws-secretsmanager"
44
import {SecretWithParameter} from "../constructs/SecretWithParameter"
55

66
export interface SecretsProps {
7-
slackBotToken: string
8-
slackSigningSecret: string
7+
readonly stackName: string
8+
readonly slackBotToken: string
9+
readonly slackSigningSecret: string
910
}
1011

1112
export class Secrets extends Construct {
@@ -19,16 +20,16 @@ export class Secrets extends Construct {
1920

2021
// Create Slack bot OAuth token secret and parameter
2122
const slackBotToken = new SecretWithParameter(this, "SlackBotToken", {
22-
secretName: "/eps-assist/slack/bot-token",
23-
parameterName: "/eps-assist/slack/bot-token/parameter",
23+
secretName: `/${props.stackName}/bot-token`,
24+
parameterName: `/${props.stackName}/bot-token/parameter`,
2425
description: "Slack Bot OAuth Token for EPS Assist",
2526
secretValue: JSON.stringify({token: props.slackBotToken})
2627
})
2728

2829
// Create Slack signing secret for request verification
2930
const slackBotSigning = new SecretWithParameter(this, "SlackBotSigning", {
30-
secretName: "/eps-assist/slack/signing-secret",
31-
parameterName: "/eps-assist/slack/signing-secret/parameter",
31+
secretName: `/${props.stackName}/signing-secret`,
32+
parameterName: `/${props.stackName}/signing-secret/parameter`,
3233
description: "Slack Signing Secret",
3334
secretValue: JSON.stringify({secret: props.slackSigningSecret})
3435
})

0 commit comments

Comments
 (0)