correct pr processing

Author: anthony-nhs

packages/slackBotFunction/app/slack/slack_events.py

@@ -256,12 +256,13 @@ def process_pull_request_slack_event(slack_event_data: Dict[str, Any]) -> None:
     # separate function to process pull requests so that we can ensure we store session information
     try:
         event_id = slack_event_data["event_id"]
+        event = slack_event_data["event"]
         if is_duplicate_event(event_id=event_id):
             return
-        message_text = slack_event_data["event"]["text"]
+        message_text = event["text"]
         _, extracted_message = extract_pull_request_id(message_text)
-        slack_event_data["event"]["text"] = extracted_message
-        process_async_slack_event(slack_event_data=slack_event_data)
+        event["text"] = extracted_message
+        process_async_slack_event(event=event, event_id=event_id)
     except Exception:
         # we cant post a reply to slack for this error as we may not have details about where to post it
         logger.error("Error processing message", extra={"event_id": event_id, "error": traceback.format_exc()})

packages/slackBotFunction/tests/test_pulll_request_processing.py

@@ -31,16 +31,13 @@ def test_process_pull_request_event(mock_extract_pull_request_id: Mock, mock_is_
 
         # assertions
         expected_slack_event_data = {
-            "event": {
-                "text": "test question",
-                "user": "U456",
-                "channel": "C789",
-                "ts": "1234567890.123",
-                "thread_ts": "1234567888.111",  # Existing thread
-            },
-            "event_id": "evt123",
+            "text": "test question",
+            "user": "U456",
+            "channel": "C789",
+            "ts": "1234567890.123",
+            "thread_ts": "1234567888.111",  # Existing thread
         }
-        mock_process_async_slack_event.assert_called_once_with(slack_event_data=expected_slack_event_data)
+        mock_process_async_slack_event.assert_called_once_with(event=expected_slack_event_data, event_id="evt123")
 
 
 @patch("app.utils.handler_utils.is_duplicate_event")