more types

Author: anthony-nhs

packages/slackBotFunction/app/handler.py

@@ -35,7 +35,7 @@ def handler(event: dict, context: LambdaContext) -> dict:
             logger.error("Async processing requested but no slack_event provided")
             return {"statusCode": 400}
 
-        process_async_slack_event(slack_event_data)
+        process_async_slack_event(slack_event_data=slack_event_data)
         return {"statusCode": 200}
 
     # handle async processing requests
@@ -45,9 +45,9 @@ def handler(event: dict, context: LambdaContext) -> dict:
             logger.error("Async processing requested but no slack_event provided")
             return {"statusCode": 400}
 
-        process_pull_request_slack_event(slack_event_data)
+        process_pull_request_slack_event(slack_event_data=slack_event_data)
         return {"statusCode": 200}
 
     # handle Slack webhook requests
     slack_handler = SlackRequestHandler(app=app)
-    return slack_handler.handle(event, context)
+    return slack_handler.handle(event=event, context=context)

packages/slackBotFunction/app/slack/slack_events.py

@@ -333,7 +333,7 @@ def store_feedback(
 
         # Get latest bot message timestamp for feedback linking
         if not message_ts:
-            message_ts = get_latest_message_ts(conversation_key)
+            message_ts = get_latest_message_ts(conversation_key=conversation_key)
 
         if message_ts and feedback_type in ["positive", "negative"]:
             # Per-message feedback with deduplication for button votes only
@@ -375,7 +375,7 @@ def store_feedback(
 
         # Mark Q&A as having received feedback to prevent deletion
         if message_ts:
-            _mark_qa_feedback_received(conversation_key, message_ts)
+            _mark_qa_feedback_received(conversation_key=conversation_key, message_ts=message_ts)
 
         logger.info(
             "Stored feedback",
@@ -403,7 +403,7 @@ def get_conversation_session(conversation_key: str) -> str | None:
     """
     Get existing Bedrock session for this conversation
     """
-    session_data = get_conversation_session_data(conversation_key)
+    session_data = get_conversation_session_data(conversation_key=conversation_key)
     return session_data.get("session_id") if session_data else None
 
 
@@ -412,7 +412,7 @@ def get_conversation_session_data(conversation_key: str) -> Dict[str, Any]:
     Get full session data for this conversation
     """
     try:
-        response = get_state_information({"pk": conversation_key, "sk": "session"})
+        response = get_state_information(key={"pk": conversation_key, "sk": "session"})
         if "Item" in response:
             logger.info("Found existing session", extra={"conversation_key": conversation_key})
             return response["Item"]
@@ -427,7 +427,7 @@ def get_latest_message_ts(conversation_key: str) -> str | None:
     Get latest message timestamp from session
     """
     try:
-        response = get_state_information({"pk": conversation_key, "sk": constants.SESSION_SK})
+        response = get_state_information(key={"pk": conversation_key, "sk": constants.SESSION_SK})
         if "Item" in response:
             return response["Item"].get("latest_message_ts")
         return None
@@ -477,9 +477,9 @@ def update_session_latest_message(conversation_key: str, message_ts: str) -> Non
     """
     try:
         update_state_information(
-            {"pk": conversation_key, "sk": constants.SESSION_SK},
-            "SET latest_message_ts = :ts",
-            {":ts": message_ts},
+            key={"pk": conversation_key, "sk": constants.SESSION_SK},
+            update_expression="SET latest_message_ts = :ts",
+            expression_attribute_values={":ts": message_ts},
         )
     except Exception:
         logger.error("Error updating session latest message", extra={"error": traceback.format_exc()})

packages/slackBotFunction/app/slack/slack_handlers.py

@@ -16,7 +16,6 @@
 from slack_sdk import WebClient
 from app.core.config import (
     BOT_MESSAGES,
-    get_bot_token,
     get_logger,
     constants,
 )
@@ -60,18 +59,17 @@ def mention_handler(event: Dict[str, Any], ack: Ack, body: Dict[str, Any], clien
     - If text after the mention starts with 'feedback:', store it as additional feedback.
     - Otherwise, forward to the async processing pipeline (Q&A).
     """
-    bot_token = get_bot_token()
     logger.debug("Sending ack response in mention_handler")
     ack()
-    respond_with_eyes(bot_token, event)
-    event_id = gate_common(event, body)
+    respond_with_eyes(event=event)
+    event_id = gate_common(event=event, body=body)
     if not event_id:
         return
     original_message_text = (event.get("text") or "").strip()
     user_id = event.get("user", "unknown")
-    conversation_key, thread_root = conversation_key_and_root(event)
+    conversation_key, thread_root = conversation_key_and_root(event=event)
 
-    message_text = strip_mentions(original_message_text)
+    message_text = strip_mentions(message_text=original_message_text)
     logger.info(f"Processing @mention from user {user_id}", extra={"event_id": event_id})
     _common_message_handler(
         message_text=message_text,
@@ -94,7 +92,7 @@ def dm_message_handler(event: Dict[str, Any], event_id: str, client: WebClient,
         return  # not a DM; the channel handler will evaluate it
     message_text = (event.get("text") or "").strip()
     user_id = event.get("user", "unknown")
-    conversation_key, thread_root = conversation_key_and_root(event)
+    conversation_key, thread_root = conversation_key_and_root(event=event)
     logger.info(f"Processing DM from user {user_id}", extra={"event_id": event_id})
     _common_message_handler(
         message_text=message_text,
@@ -127,7 +125,7 @@ def thread_message_handler(event: Dict[str, Any], event_id: str, client: WebClie
 
     conversation_key = f"{constants.THREAD_PREFIX}{channel_id}#{thread_root}"
     try:
-        resp = get_state_information({"pk": conversation_key, "sk": constants.SESSION_SK})
+        resp = get_state_information(key={"pk": conversation_key, "sk": constants.SESSION_SK})
         if "Item" not in resp:
             logger.info(f"No session found for thread: {conversation_key}")
             return  # not a bot-owned thread; ignore
@@ -152,9 +150,8 @@ def unified_message_handler(event: Dict[str, Any], ack: Ack, body: Dict[str, Any
     """Handle all message events - DMs and channel messages"""
     logger.debug("Sending ack response")
     ack()
-    bot_token = get_bot_token()
-    respond_with_eyes(bot_token, event)
-    event_id = gate_common(event, body)
+    respond_with_eyes(event=event)
+    event_id = gate_common(event=event, body=body)
     if not event_id:
         return
 
@@ -179,7 +176,7 @@ def feedback_handler(ack: Ack, body: Dict[str, Any], client: WebClient) -> None:
         conversation_key = feedback_data["ck"]
         message_ts = feedback_data.get("mt")
 
-        if message_ts and not is_latest_message(conversation_key, message_ts):
+        if message_ts and not is_latest_message(conversation_key=conversation_key, message_ts=message_ts):
             logger.info(f"Feedback ignored - not latest message: {message_ts}")
             return
 

packages/slackBotFunction/app/utils/handler_utils.py

@@ -16,6 +16,7 @@
 
 from app.services.dynamo import get_state_information, store_state_information
 from app.core.config import (
+    get_bot_token,
     get_logger,
     constants,
 )
@@ -67,7 +68,8 @@ def trigger_async_processing(event: Dict[str, Any], event_id: str) -> None:
         logger.error("Failed to trigger async processing", extra={"error": traceback.format_exc()})
 
 
-def respond_with_eyes(bot_token: str, event: Dict[str, Any]) -> None:
+def respond_with_eyes(event: Dict[str, Any]) -> None:
+    bot_token = get_bot_token()
     client = WebClient(token=bot_token)
     channel = event["channel"]
     ts = event["ts"]
@@ -137,9 +139,9 @@ def gate_common(event: Dict[str, Any], body: Dict[str, Any]) -> str | None:
     return event_id
 
 
-def strip_mentions(text: str) -> str:
+def strip_mentions(message_text: str) -> str:
     """Remove Slack user mentions like <@U123> or <@U123|alias> from text."""
-    return re.sub(r"<@[UW][A-Z0-9]+(\|[^>]+)?>", "", text or "").strip()
+    return re.sub(r"<@[UW][A-Z0-9]+(\|[^>]+)?>", "", message_text or "").strip()
 
 
 def extract_pull_request_id(text: str) -> str:

packages/slackBotFunction/tests/test_handler_utils.py

@@ -230,7 +230,7 @@ def test_respond_with_eyes_on_success(mock_webclient: Mock, mock_env: Mock):
 
     # perform operation
     event = {"channel": "D123", "ts": "456", "channel_type": "im"}
-    respond_with_eyes("dummy_token", event)
+    respond_with_eyes(event)
 
     # assertions
     # just need to make sure it does not error
@@ -251,7 +251,7 @@ def test_respond_with_eyes_on_failure(mock_webclient: Mock, mock_env: Mock):
 
     # perform operation
     event = {"channel": "D123", "ts": "456", "channel_type": "im"}
-    respond_with_eyes("dummy_token", event)
+    respond_with_eyes(event)
 
     # assertions
     # just need to make sure it does not error

packages/slackBotFunction/tests/test_handlers.py

@@ -22,7 +22,7 @@ def test_handler_normal_event(
     result = handler(event, lambda_context)
 
     # assertions
-    mock_handler.handle.assert_called_once_with(event, lambda_context)
+    mock_handler.handle.assert_called_once_with(event=event, context=lambda_context)
     assert result["statusCode"] == 200