error handling

Author: anthony-nhs

packages/slackBotFunction/app/slack/slack_events.py

@@ -267,13 +267,17 @@ def process_async_slack_event(slack_event_data: Dict[str, Any]) -> None:
 
 def process_pull_request_slack_event(slack_event_data: Dict[str, Any]) -> None:
     # separate function to process pull requests so that we can ensure we store session information
-    event_id = slack_event_data["event_id"]
-    if is_duplicate_event(event_id=event_id):
-        return
-    message_text = slack_event_data["event"]["text"]
-    _, extracted_message = extract_pull_request_id(message_text)
-    slack_event_data["event"]["text"] = extracted_message
-    process_async_slack_event(slack_event_data=slack_event_data)
+    try:
+        event_id = slack_event_data["event_id"]
+        if is_duplicate_event(event_id=event_id):
+            return
+        message_text = slack_event_data["event"]["text"]
+        _, extracted_message = extract_pull_request_id(message_text)
+        slack_event_data["event"]["text"] = extracted_message
+        process_async_slack_event(slack_event_data=slack_event_data)
+    except Exception:
+        # we cant post a reply to slack for this error as we may not have details about where to post it
+        logger.error("Error processing message", extra={"event_id": event_id, "error": traceback.format_exc()})
 
 
 def log_query_stats(user_query: str, event: Dict[str, Any], channel: str, client: WebClient, thread_ts: str) -> None:

packages/slackBotFunction/app/utils/handler_utils.py

@@ -145,7 +145,7 @@ def strip_mentions(message_text: str) -> str:
 
 
 def extract_pull_request_id(text: str) -> Tuple[str, str]:
-    # Regex: '#pr' + optional space + number + space + rest of text
+    # Regex: PULL_REQUEST_PREFIX + optional space + number + space + rest of text
     pattern = re.escape(constants.PULL_REQUEST_PREFIX) + r"\s*(\d+)\s+(.+)"
     match = re.match(pattern, text)
     if not match: