return dynamo item

Author: anthony-nhs

packages/slackBotFunction/app/services/dynamo.py

@@ -3,7 +3,7 @@
 
 def get_state_information(key):
     table = get_slack_bot_state_table()
-    table.get_item(Key=key)
+    return table.get_item(Key=key)
 
 
 def store_state_information(item, condition=None):

packages/slackBotFunction/app/slack/slack_events.py

@@ -45,13 +45,13 @@ def cleanup_previous_unfeedback_qa(conversation_key, current_message_ts, session
         )
         logger.info("Deleted unfeedback Q&A for privacy", extra={"message_ts": previous_message_ts})
 
-    except ClientError as e:
+    except ClientError:
         if e.response.get("Error", {}).get("Code") == "ConditionalCheckFailedException":
             logger.info("Q&A has feedback - keeping for user", extra={"message_ts": previous_message_ts})
         else:
-            logger.error("Error cleaning up Q&A", extra={"error": str(e)})
-    except Exception as e:
-        logger.error("Error cleaning up unfeedback Q&A", extra={"error": str(e)})
+            logger.error("Error cleaning up Q&A", extra={"error": traceback.format_exc()})
+    except Exception:
+        logger.error("Error cleaning up unfeedback Q&A", extra={"error": traceback.format_exc()})
 
 
 def store_qa_pair(conversation_key, user_query, bot_response, message_ts, session_id, user_id):
@@ -72,8 +72,8 @@ def store_qa_pair(conversation_key, user_query, bot_response, message_ts, sessio
         }
         store_state_information(item=item)
         logger.info("Stored Q&A pair", extra={"conversation_key": conversation_key, "message_ts": message_ts})
-    except Exception as e:
-        logger.error("Failed to store Q&A pair", extra={"error": str(e)})
+    except Exception:
+        logger.error("Failed to store Q&A pair", extra={"error": traceback.format_exc()})
 
 
 def _mark_qa_feedback_received(conversation_key, message_ts):
@@ -86,8 +86,8 @@ def _mark_qa_feedback_received(conversation_key, message_ts):
             "SET feedback_received = :val",
             {":val": True},
         )
-    except Exception as e:
-        logger.error("Error marking Q&A feedback received", extra={"error": str(e)})
+    except Exception:
+        logger.error("Error marking Q&A feedback received", extra={"error": traceback.format_exc()})
 
 
 # ================================================================
@@ -238,7 +238,8 @@ def process_async_slack_event(slack_event_data):
             client.chat_update(channel=channel, ts=message_ts, text=response_text, blocks=blocks)
         except Exception as e:
             logger.error(
-                f"Failed to attach feedback buttons: {e}", extra={"event_id": event_id, "message_ts": message_ts}
+                f"Failed to attach feedback buttons: {e}",
+                extra={"event_id": event_id, "message_ts": message_ts, "error": traceback.format_exc()},
             )
 
     except Exception:
@@ -250,8 +251,8 @@ def process_async_slack_event(slack_event_data):
             if thread_ts:  # Only add thread_ts for channel threads, not DMs
                 post_params["thread_ts"] = thread_ts
             client.chat_postMessage(**post_params)
-        except Exception as post_err:
-            logger.error("Failed to post error message", extra={"error": str(post_err)})
+        except Exception:
+            logger.error("Failed to post error message", extra={"error": traceback.format_exc()})
 
 
 # ================================================================
@@ -332,10 +333,10 @@ def store_feedback(
         )
 
     except ClientError as e:
-        logger.error(f"Error storing feedback: {e}")
+        logger.error(f"Error storing feedback: {e}", extra={"error": traceback.format_exc()})
         raise
     except Exception as e:
-        logger.error(f"Error storing feedback: {e}")
+        logger.error(f"Error storing feedback: {e}", extra={"error": traceback.format_exc()})
 
 
 # ================================================================
@@ -375,8 +376,8 @@ def get_latest_message_ts(conversation_key):
         if "Item" in response:
             return response["Item"].get("latest_message_ts")
         return None
-    except Exception as e:
-        logger.error("Error getting latest message timestamp", extra={"error": str(e)})
+    except Exception:
+        logger.error("Error getting latest message timestamp", extra={"error": traceback.format_exc()})
         return None
 
 
@@ -420,5 +421,5 @@ def update_session_latest_message(conversation_key, message_ts):
             "SET latest_message_ts = :ts",
             {":ts": message_ts},
         )
-    except Exception as e:
-        logger.error("Error updating session latest message", extra={"error": str(e)})
+    except Exception:
+        logger.error("Error updating session latest message", extra={"error": traceback.format_exc()})

packages/slackBotFunction/app/slack/slack_handlers.py

@@ -10,6 +10,7 @@
 import json
 import re
 from functools import lru_cache
+import traceback
 from botocore.exceptions import ClientError
 from app.core.config import (
     get_bot_messages,
@@ -113,7 +114,7 @@ def mention_handler(event, ack, body, client):
                 feedback_text,
             )
         except Exception as e:
-            logger.error(f"Failed to store channel feedback via mention: {e}")
+            logger.error(f"Failed to store channel feedback via mention: {e}", extra={"error": traceback.format_exc()})
         BOT_MESSAGES = get_bot_messages()
         try:
             client.chat_postMessage(
@@ -122,7 +123,7 @@ def mention_handler(event, ack, body, client):
                 thread_ts=thread_root,
             )
         except Exception as e:
-            logger.error(f"Failed to post channel feedback ack: {e}")
+            logger.error(f"Failed to post channel feedback ack: {e}", extra={"error": traceback.format_exc()})
         return
 
     # Normal mention -> async processing
@@ -158,7 +159,7 @@ def dm_message_handler(event, event_id, client):
                 feedback_text,
             )
         except Exception as e:
-            logger.error(f"Failed to store DM additional feedback: {e}")
+            logger.error(f"Failed to store DM additional feedback: {e}", extra={"error": traceback.format_exc()})
         BOT_MESSAGES = get_bot_messages()
 
         try:
@@ -168,7 +169,7 @@ def dm_message_handler(event, event_id, client):
                 text=BOT_MESSAGES["feedback_thanks"],
             )
         except Exception as e:
-            logger.error(f"Failed to post DM feedback ack: {e}")
+            logger.error(f"Failed to post DM feedback ack: {e}", extra={"error": traceback.format_exc()})
         return
 
     # Normal DM -> async processing
@@ -200,7 +201,7 @@ def thread_message_handler(event, event_id, client):
             return  # not a bot-owned thread; ignore
         logger.info(f"Found session for thread: {conversation_key}")
     except Exception as e:
-        logger.error(f"Error checking thread session: {e}")
+        logger.error(f"Error checking thread session: {e}", extra={"error": traceback.format_exc()})
         return
 
     if text.lower().startswith(constants.FEEDBACK_PREFIX):
@@ -217,7 +218,7 @@ def thread_message_handler(event, event_id, client):
                 feedback_text,
             )
         except Exception as e:
-            logger.error(f"Failed to store channel additional feedback: {e}")
+            logger.error(f"Failed to store channel additional feedback: {e}", extra={"error": traceback.format_exc()})
 
         try:
             BOT_MESSAGES = get_bot_messages()
@@ -228,7 +229,7 @@ def thread_message_handler(event, event_id, client):
                 thread_ts=thread_root,
             )
         except Exception as e:
-            logger.error(f"Failed to post channel feedback ack: {e}")
+            logger.error(f"Failed to post channel feedback ack: {e}", extra={"error": traceback.format_exc()})
         return
 
     # Follow-up in a bot-owned thread (no re-mention required)
@@ -302,11 +303,11 @@ def feedback_handler(ack, body, client):
                 # Silently ignore duplicate votes - user already voted on this message
                 logger.info(f"Duplicate vote ignored for user {body['user']['id']}")
                 return
-            logger.error(f"Feedback storage error: {e}")
+            logger.error(f"Feedback storage error: {e}", extra={"error": traceback.format_exc()})
         except Exception as e:
-            logger.error(f"Unexpected feedback error: {e}")
+            logger.error(f"Unexpected feedback error: {e}", extra={"error": traceback.format_exc()})
     except Exception as e:
-        logger.error(f"Error handling feedback: {e}")
+        logger.error(f"Error handling feedback: {e}", extra={"error": traceback.format_exc()})
 
 
 # ================================================================
@@ -337,5 +338,5 @@ def _is_latest_message(conversation_key, message_ts):
             return latest_message_ts == message_ts
         return False
     except Exception as e:
-        logger.error(f"Error checking latest message: {e}")
+        logger.error(f"Error checking latest message: {e}", extra={"error": traceback.format_exc()})
         return False

scripts/run_sync.sh

@@ -10,10 +10,10 @@ EPSAM_CONFIG=".local_config/epsam_app.config.json"
 EPSAM_LOG=".local_config/epsam_app.log"
 
 if [ -z "${PULL_REQUEST_ID}" ]; then
-    echo "What is the pull request id?"
+    echo "What is the pull request id? "
     read -r PULL_REQUEST_ID
 else
-    read -r -p "Getting exports for pull request id ${PULL_REQUEST_ID}. Is this correct?" yn
+    read -r -p "Getting exports for pull request id ${PULL_REQUEST_ID}. Is this correct? " yn
     case $yn in
         [Yy]* ) ;;
         [Nn]* ) exit;;

scripts/sync_docs.sh

@@ -2,10 +2,10 @@
 set -e
 
 if [ -z "${PULL_REQUEST_ID}" ]; then
-    echo "What is the pull request id?"
+    echo "What is the pull request id? "
     read -r PULL_REQUEST_ID
 else
-    read -r -p "Getting exports for pull request id ${PULL_REQUEST_ID}. Is this correct?" yn
+    read -r -p "Getting exports for pull request id ${PULL_REQUEST_ID}. Is this correct? " yn
     case $yn in
         [Yy]* ) ;;
         [Nn]* ) exit;;