Update test suites to improve coverage

Author: kris-szlapa

packages/slackBotFunction/tests/test_feedback.py

@@ -107,3 +107,76 @@ def test_update_session_latest_message_error_handling(mock_table, mock_env):
 
     # Should not raise exception
     update_session_latest_message("conv-key", "123")
+
+
+@patch("app.slack.slack_events.table")
+@patch("time.time")
+def test_store_feedback_with_qa_fallback_paths(mock_time, mock_table, mock_env):
+    """Test store_feedback_with_qa fallback paths"""
+    mock_time.return_value = 1000
+    from app.slack.slack_events import store_feedback_with_qa
+
+    with patch("app.slack.slack_events.get_latest_message_ts", return_value=None):
+        store_feedback_with_qa("conv-key", "query", "response", "positive", "user-id", "channel-id")
+        mock_table.put_item.assert_called()
+
+
+@patch("app.slack.slack_events.table")
+def test_cleanup_previous_unfeedback_qa(mock_table, mock_env):
+    """Test cleanup_previous_unfeedback_qa function"""
+    from app.slack.slack_events import cleanup_previous_unfeedback_qa
+
+    # Test with no previous message
+    session_data = {}
+    cleanup_previous_unfeedback_qa("conv-key", "123", session_data)
+    mock_table.delete_item.assert_not_called()
+
+    # Test with same message timestamp
+    session_data = {"latest_message_ts": "123"}
+    cleanup_previous_unfeedback_qa("conv-key", "123", session_data)
+    mock_table.delete_item.assert_not_called()
+
+    # Test with different message timestamp and no feedback
+    mock_table.reset_mock()
+    session_data = {"latest_message_ts": "456"}
+    with patch("app.slack.slack_events.check_feedback_exists", return_value=False):
+        cleanup_previous_unfeedback_qa("conv-key", "123", session_data)
+        mock_table.delete_item.assert_called_once_with(Key={"pk": "qa#conv-key#456", "sk": "turn"})
+
+    # Test with different message timestamp and existing feedback
+    mock_table.reset_mock()
+    with patch("app.slack.slack_events.check_feedback_exists", return_value=True):
+        cleanup_previous_unfeedback_qa("conv-key", "123", session_data)
+        mock_table.delete_item.assert_not_called()
+
+
+@patch("app.slack.slack_events.table")
+def test_check_feedback_exists(mock_table, mock_env):
+    """Test check_feedback_exists function"""
+    from app.slack.slack_events import check_feedback_exists
+
+    # Test with existing feedback
+    mock_table.query.return_value = {"Items": [{"feedback_type": "positive"}]}
+    result = check_feedback_exists("conv-key", "123")
+    assert result is True
+
+    # Test with no feedback
+    mock_table.query.return_value = {"Items": []}
+    result = check_feedback_exists("conv-key", "123")
+    assert result is False
+
+    # Test with exception
+    mock_table.query.side_effect = Exception("DB error")
+    result = check_feedback_exists("conv-key", "123")
+    assert result is False
+
+
+@patch("app.slack.slack_events.table")
+def test_cleanup_previous_unfeedback_qa_error_handling(mock_table, mock_env):
+    """Test cleanup_previous_unfeedback_qa error handling"""
+    from app.slack.slack_events import cleanup_previous_unfeedback_qa
+
+    session_data = {"latest_message_ts": "456"}
+    with patch("app.slack.slack_events.check_feedback_exists", side_effect=Exception("Error")):
+        # Should not raise exception
+        cleanup_previous_unfeedback_qa("conv-key", "123", session_data)

packages/slackBotFunction/tests/test_slack_handlers.py

@@ -391,3 +391,84 @@ def test_channel_message_handler_session_check_error(mock_env):
         mock_table.get_item.side_effect = Exception("DB error")
         # Should return early due to error
         channel_message_handler(mock_event, "evt123", mock_body, mock_client)
+
+
+def test_feedback_handler_unknown_action(mock_env):
+    """Test feedback_handler with unknown action"""
+    from app.slack.slack_handlers import feedback_handler
+
+    mock_ack = Mock()
+    mock_body = {"actions": [{"action_id": "unknown_action", "value": "{}"}]}
+    mock_client = Mock()
+
+    feedback_handler(mock_ack, mock_body, mock_client)
+    mock_ack.assert_called_once()
+
+
+def test_feedback_handler_not_latest_message(mock_env):
+    """Test feedback_handler when not latest message"""
+    from app.slack.slack_handlers import feedback_handler
+
+    mock_ack = Mock()
+    mock_body = {"actions": [{"action_id": "feedback_yes", "value": '{"ck": "conv-key", "mt": "123"}'}]}
+    mock_client = Mock()
+
+    with patch("app.slack.slack_handlers._is_latest_message", return_value=False):
+        feedback_handler(mock_ack, mock_body, mock_client)
+        mock_ack.assert_called_once()
+
+
+def test_channel_message_handler_no_session(mock_env):
+    """Test channel_message_handler when no session found"""
+    from app.slack.slack_handlers import channel_message_handler
+
+    mock_client = Mock()
+    mock_event = {"text": "follow up", "channel": "C789", "thread_ts": "123", "user": "U456"}
+    mock_body = {"event_id": "evt123"}
+
+    with patch("app.core.config.table") as mock_table:
+        mock_table.get_item.return_value = {}  # No session
+        channel_message_handler(mock_event, "evt123", mock_body, mock_client)
+
+
+def test_channel_message_handler_feedback_path(mock_env):
+    """Test channel_message_handler feedback path"""
+    from app.slack.slack_handlers import channel_message_handler
+
+    mock_client = Mock()
+    mock_event = {"text": "feedback: channel feedback", "channel": "C789", "thread_ts": "123", "user": "U456"}
+    mock_body = {"event_id": "evt123"}
+
+    with patch("app.core.config.table") as mock_table:
+        mock_table.get_item.return_value = {"Item": {"session_id": "session123"}}
+        # Just test that the function runs without error
+        channel_message_handler(mock_event, "evt123", mock_body, mock_client)
+
+
+def test_dm_message_handler_normal_message(mock_env):
+    """Test dm_message_handler with normal message"""
+    from app.slack.slack_handlers import dm_message_handler
+
+    mock_client = Mock()
+    mock_event = {"text": "normal message", "user": "U456", "channel": "D789", "ts": "123", "channel_type": "im"}
+    mock_body = {"event_id": "evt123"}
+
+    with patch("app.slack.slack_handlers._trigger_async_processing") as mock_trigger:
+        dm_message_handler(mock_event, "evt123", mock_body, mock_client)
+        mock_trigger.assert_called_once()
+
+
+def test_app_mention_handler_normal_mention(mock_env):
+    """Test app_mention_handler with normal mention"""
+    from app.slack.slack_handlers import app_mention_handler
+
+    mock_ack = Mock()
+    mock_client = Mock()
+    mock_event = {"text": "<@U123> normal question", "user": "U456", "channel": "C789", "ts": "123"}
+    mock_body = {"event_id": "evt123"}
+
+    with patch("app.slack.slack_handlers._is_duplicate_event", return_value=False), patch(
+        "app.slack.slack_handlers._trigger_async_processing"
+    ) as mock_trigger:
+        app_mention_handler(mock_event, mock_ack, mock_body, mock_client)
+        mock_trigger.assert_called_once()