Merge branch 'pull_request_conversation_1' into pull_request_conversation_2

Author: anthony-nhs

packages/slackBotFunction/app/slack/slack_events.py

@@ -244,10 +244,9 @@ def process_async_slack_action(body: Dict[str, Any], client: WebClient) -> None:
                 client=client,
             )
             # Only post message if storage succeeded
-            post_params = {"channel": feedback_data["ch"], "text": response_message}
-            if feedback_data.get("tt"):  # Only add thread_ts if it exists (not for DMs)
-                post_params["thread_ts"] = feedback_data["tt"]
-            client.chat_postMessage(**post_params)
+            client.chat_postMessage(
+                channel=feedback_data["ch"], text=response_message, thread_ts=feedback_data.get("tt")
+            )
         except ClientError as e:
             if e.response.get("Error", {}).get("Code") == "ConditionalCheckFailedException":
                 # Silently ignore duplicate votes - user already voted on this message

packages/slackBotFunction/tests/test_async_processing.py

@@ -122,7 +122,9 @@ def client_side_effect(service_name, *args, **kwargs):
     with patch("app.utils.handler_utils.get_pull_request_lambda_arn") as mock_get_pull_request_lambda_arn:
         mock_get_pull_request_lambda_arn.side_effect = Exception("Error getting lambda arn")
         with pytest.raises(Exception):
-            forward_event_to_pull_request_lambda(pull_request_id="123", event=event_data, event_id="evt123")
+            forward_event_to_pull_request_lambda(
+                pull_request_id="123", event=event_data, event_id="evt123", store_pull_request_id=False
+            )
 
         # assertions