even more typing

Author: anthony-nhs

packages/slackBotFunction/app/services/bedrock.py

@@ -1,4 +1,5 @@
 import json
+from typing import Any
 import boto3
 from mypy_boto3_bedrock_agent_runtime import AgentsforBedrockRuntimeClient
 from mypy_boto3_bedrock_runtime.client import BedrockRuntimeClient
@@ -55,7 +56,7 @@ def query_bedrock(user_query: str, session_id: str = None) -> RetrieveAndGenerat
     return response
 
 
-def invoke_model(prompt: str, model_id: str, client: BedrockRuntimeClient):
+def invoke_model(prompt: str, model_id: str, client: BedrockRuntimeClient) -> dict[str, Any]:
     response = client.invoke_model(
         modelId=model_id,
         body=json.dumps(

packages/slackBotFunction/app/services/dynamo.py

@@ -29,7 +29,7 @@ def get_state_information(key: str) -> GetItemOutputTableTypeDef:
     return results
 
 
-def store_state_information(item: dict[str, Any], condition: str = None):
+def store_state_information(item: dict[str, Any], condition: str = None) -> None:
     start_time = time()
     table = get_slack_bot_state_table()
     is_success = True
@@ -54,7 +54,7 @@ def store_state_information(item: dict[str, Any], condition: str = None):
         )
 
 
-def update_state_information(key: str, update_expression: str, expression_attribute_values: dict[str, Any]):
+def update_state_information(key: str, update_expression: str, expression_attribute_values: dict[str, Any]) -> None:
     start_time = time()
     table = get_slack_bot_state_table()
     is_success = True
@@ -78,7 +78,7 @@ def update_state_information(key: str, update_expression: str, expression_attrib
         )
 
 
-def delete_state_information(pk: str, sk: str, condition: str):
+def delete_state_information(pk: str, sk: str, condition: str) -> None:
     start_time = time()
     table = get_slack_bot_state_table()
     is_success = True

packages/slackBotFunction/app/slack/slack_events.py

@@ -34,7 +34,9 @@
 # ================================================================
 
 
-def cleanup_previous_unfeedback_qa(conversation_key: str, current_message_ts: str, session_data: Dict[str, Any]):
+def cleanup_previous_unfeedback_qa(
+    conversation_key: str, current_message_ts: str, session_data: Dict[str, Any]
+) -> None:
     """Delete previous Q&A pair if no feedback received using atomic operation"""
     try:
         previous_message_ts = session_data.get("latest_message_ts")
@@ -59,7 +61,7 @@ def cleanup_previous_unfeedback_qa(conversation_key: str, current_message_ts: st
 
 def store_qa_pair(
     conversation_key: str, user_query: str, bot_response: str, message_ts: str, session_id: str, user_id: str
-):
+) -> None:
     """
     Store Q&A pair for feedback correlation
     """
@@ -81,7 +83,7 @@ def store_qa_pair(
         logger.error("Failed to store Q&A pair", extra={"error": traceback.format_exc()})
 
 
-def _mark_qa_feedback_received(conversation_key: str, message_ts: str):
+def _mark_qa_feedback_received(conversation_key: str, message_ts: str) -> None:
     """
     Mark Q&A record as having received feedback to prevent deletion
     """
@@ -121,7 +123,7 @@ def _handle_session_management(
     thread_ts: str,
     context_type: str,
     message_ts: str,
-):
+) -> None:
     """Handle Bedrock session creation and cleanup"""
     # Handle conversation session management
     if not session_id and "sessionId" in kb_response:
@@ -179,7 +181,7 @@ def _create_feedback_blocks(
 # ================================================================
 
 
-def process_async_slack_event(slack_event_data: Dict[str, Any]):
+def process_async_slack_event(slack_event_data: Dict[str, Any]) -> None:
     """
     Process Slack events asynchronously after initial acknowledgment
 
@@ -268,7 +270,7 @@ def process_async_slack_event(slack_event_data: Dict[str, Any]):
             logger.error("Failed to post error message", extra={"error": traceback.format_exc()})
 
 
-def log_query_stats(user_query: str, event: Dict[str, Any], channel: str, client: WebClient, thread_ts: str):
+def log_query_stats(user_query: str, event: Dict[str, Any], channel: str, client: WebClient, thread_ts: str) -> None:
     query_length = len(user_query)
     start_time = float(event["event_ts"])
     end_time = time.time()
@@ -301,7 +303,7 @@ def store_feedback(
     thread_ts: str = None,
     message_ts: str = None,
     feedback_text: str = None,
-):
+) -> None:
     """
     Store user feedback with reference to Q&A record
     """
@@ -429,7 +431,7 @@ def store_conversation_session(
     channel_id: str,
     thread_ts: str = None,
     latest_message_ts: str = None,
-):
+) -> None:
     """
     Store new Bedrock session for conversation memory
     """
@@ -457,7 +459,7 @@ def store_conversation_session(
         logger.error("Error storing session", extra={"error": traceback.format_exc()})
 
 
-def update_session_latest_message(conversation_key: str, message_ts: str):
+def update_session_latest_message(conversation_key: str, message_ts: str) -> None:
     """
     Update session with latest message timestamp
     """

packages/slackBotFunction/app/slack/slack_handlers.py

@@ -40,7 +40,7 @@
 
 
 @lru_cache
-def setup_handlers(app: App):
+def setup_handlers(app: App) -> None:
     """Register handlers. Intentionally minimal—no branching here."""
     app.event("app_mention")(mention_handler)
     app.event("message")(unified_message_handler)
@@ -53,7 +53,7 @@ def setup_handlers(app: App):
 # ================================================================
 
 
-def mention_handler(event: Dict[str, Any], ack: Ack, body: Dict[str, Any], client: WebClient):
+def mention_handler(event: Dict[str, Any], ack: Ack, body: Dict[str, Any], client: WebClient) -> None:
     """
     Channel interactions that mention the bot.
     - If text after the mention starts with 'feedback:', store it as additional feedback.
@@ -84,7 +84,7 @@ def mention_handler(event: Dict[str, Any], ack: Ack, body: Dict[str, Any], clien
     )
 
 
-def dm_message_handler(event: Dict[str, Any], event_id, client: WebClient, body: Dict[str, Any]):
+def dm_message_handler(event: Dict[str, Any], event_id: str, client: WebClient, body: Dict[str, Any]) -> None:
     """
     Direct messages:
     - 'feedback:' prefix -> store as conversation-scoped additional feedback (no model call).
@@ -108,7 +108,7 @@ def dm_message_handler(event: Dict[str, Any], event_id, client: WebClient, body:
     )
 
 
-def thread_message_handler(event: Dict[str, Any], event_id, client: WebClient, body: Dict[str, Any]):
+def thread_message_handler(event: Dict[str, Any], event_id: str, client: WebClient, body: Dict[str, Any]) -> None:
     """
     Thread messages:
     - Ignore top-level messages (policy: require @mention to start).
@@ -150,7 +150,7 @@ def thread_message_handler(event: Dict[str, Any], event_id, client: WebClient, b
     )
 
 
-def unified_message_handler(event: Dict[str, Any], ack: Ack, body: Dict[str, Any], client: WebClient):
+def unified_message_handler(event: Dict[str, Any], ack: Ack, body: Dict[str, Any], client: WebClient) -> None:
     """Handle all message events - DMs and channel messages"""
     logger.debug("Sending ack response")
     ack()
@@ -169,7 +169,7 @@ def unified_message_handler(event: Dict[str, Any], ack: Ack, body: Dict[str, Any
         thread_message_handler(event=event, event_id=event_id, client=client, body=body)
 
 
-def feedback_handler(ack: Ack, body: Dict[str, Any], client: WebClient):
+def feedback_handler(ack: Ack, body: Dict[str, Any], client: WebClient) -> None:
     """Handle feedback button clicks (both positive and negative)."""
     logger.debug("Sending ack response")
     ack()
@@ -234,10 +234,10 @@ def _common_message_handler(
     thread_root: str,
     client: WebClient,
     event: Dict[str, Any],
-    event_id,
+    event_id: str,
     post_to_thread: bool,
     body: Dict[str, Any],
-):
+) -> None:
     channel_id = event["channel"]
     user_id = event.get("user", "unknown")
     if message_text.lower().startswith(constants.FEEDBACK_PREFIX):

packages/slackBotFunction/app/utils/handler_utils.py

@@ -44,7 +44,7 @@ def is_duplicate_event(event_id: str) -> bool:
         return False
 
 
-def trigger_async_processing(event: Dict[str, Any], event_id: str):
+def trigger_async_processing(event: Dict[str, Any], event_id: str) -> None:
     """
     Trigger asynchronous Lambda invocation to process Slack events
 
@@ -67,7 +67,7 @@ def trigger_async_processing(event: Dict[str, Any], event_id: str):
         logger.error("Failed to trigger async processing", extra={"error": traceback.format_exc()})
 
 
-def respond_with_eyes(bot_token: str, event: Dict[str, Any]):
+def respond_with_eyes(bot_token: str, event: Dict[str, Any]) -> None:
     client = WebClient(token=bot_token)
     channel = event["channel"]
     ts = event["ts"]
@@ -78,7 +78,7 @@ def respond_with_eyes(bot_token: str, event: Dict[str, Any]):
         logger.warning("Failed to respond with eyes", extra={"error": traceback.format_exc()})
 
 
-def trigger_pull_request_processing(pull_request_id: str, event: Dict[str, Any], event_id: str):
+def trigger_pull_request_processing(pull_request_id: str, event: Dict[str, Any], event_id: str) -> None:
     cloudformation_client: CloudFormationClient = boto3.client("cloudformation")
     lambda_client: LambdaClient = boto3.client("lambda")
     try:

packages/slackBotFunction/tests/conftest.py

@@ -42,7 +42,7 @@ def lambda_context():
 
 @pytest.fixture
 def mock_get_parameter():
-    def fake_get_parameter(name, *args, **kwargs):
+    def fake_get_parameter(name: str, *args, **kwargs):
         return {
             "/test/bot-token": json.dumps({"token": "test-token"}),
             "/test/signing-secret": json.dumps({"secret": "test-secret"}),