Skip to content

Commit 539967c

Browse files
authored
Fix: [AEA-0000] - enable sonar (#13)
## Summary - Routine Change ### Details - enable sonar
1 parent 87bc869 commit 539967c

File tree

4 files changed

+25
-33
lines changed

4 files changed

+25
-33
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -8,23 +8,12 @@ env:
88
BRANCH_NAME: ${{ github.ref_name }}
99

1010
jobs:
11-
# quality_checks:
12-
# uses: NHSDigital/eps-workflow-quality-checks/.github/workflows/quality-checks.yml@v2
13-
# with:
14-
# node_version: '20'
15-
# secrets:
16-
# SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
17-
1811
quality_checks:
19-
runs-on: ubuntu-latest
20-
permissions:
21-
id-token: write
22-
contents: read
23-
packages: read
24-
steps:
25-
- name: Dummy step
26-
run: |
27-
echo "Disabled quality checks for now"
12+
uses: NHSDigital/eps-workflow-quality-checks/.github/workflows/quality-checks.yml@v2
13+
with:
14+
node_version: '20'
15+
secrets:
16+
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
2817

2918
get_commit_id:
3019
runs-on: ubuntu-latest

.github/workflows/pull_request.yml

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -11,24 +11,13 @@ jobs:
1111
pr_title_format_check:
1212
uses: ./.github/workflows/pr_title_check.yml
1313

14-
# quality_checks:
15-
# uses: NHSDigital/eps-workflow-quality-checks/.github/workflows/quality-checks.yml@v2
16-
# with:
17-
# node_version: '20'
18-
# secrets:
19-
# SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
20-
2114
quality_checks:
22-
runs-on: ubuntu-latest
23-
permissions:
24-
id-token: write
25-
contents: read
26-
packages: read
27-
steps:
28-
- name: Dummy step
29-
run: |
30-
echo "Disabled quality checks for now"
31-
15+
uses: NHSDigital/eps-workflow-quality-checks/.github/workflows/quality-checks.yml@v2
16+
with:
17+
node_version: '20'
18+
secrets:
19+
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
20+
3221
get_issue_number:
3322
runs-on: ubuntu-latest
3423
outputs:

ignored_security_issues.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
[
2+
"GHSA-8rmg-jf7p-4p22"
3+
]

sonar-project.properties

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
sonar.organization=nhsdigital
2+
sonar.projectKey=NHSDigital_eps-cdk-utils
3+
sonar.host.url=https://sonarcloud.io
4+
5+
sonar.coverage.exclusions=\
6+
**/*.test.*,\
7+
**/jest.config.ts,scripts/*,\
8+
packages/common/testing/*, \
9+
eslint.config.mjs, \
10+
**/tests/*, \
11+
release.config.js

0 commit comments

Comments
 (0)