Skip to content

Commit 6e97a80

Browse files
authored
Fix: [AEA-0000] - pre install node (#35)
## Summary - Routine Change ### Details - pre install node to make things quicker
1 parent e85ca74 commit 6e97a80

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@ env:
99

1010
jobs:
1111
quality_checks:
12-
uses: NHSDigital/eps-workflow-quality-checks/.github/workflows/quality-checks.yml@v2
13-
with:
14-
node_version: '20'
12+
uses: NHSDigital/eps-workflow-quality-checks/.github/workflows/quality-checks.yml@main
1513
secrets:
1614
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
1715

.github/workflows/pull_request.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,7 @@ jobs:
1212
uses: ./.github/workflows/pr_title_check.yml
1313

1414
quality_checks:
15-
uses: NHSDigital/eps-workflow-quality-checks/.github/workflows/quality-checks.yml@v2
16-
with:
17-
node_version: '20'
15+
uses: NHSDigital/eps-workflow-quality-checks/.github/workflows/quality-checks.yml@main
1816
secrets:
1917
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
2018

docker/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ ENV PATH="$PATH:/home/cdkuser/.asdf/bin/:/home/cdkuser/node_modules/.bin"
3131

3232
# Install ASDF plugins
3333
RUN asdf plugin add nodejs https://github.com/asdf-vm/asdf-nodejs.git
34+
RUN asdf install nodejs 20.18.0
3435

3536

3637
# copy files needed for deployment

ignored_security_issues.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
11
[
2-
"GHSA-8rmg-jf7p-4p22"
2+
{
3+
"vulnerability_id": "GHSA-8rmg-jf7p-4p22",
4+
"reason": "This is a false positive. See the following links for more information. https://github.com/github/advisory-database/issues/3280 https://github.com/anchore/grype/issues/1886"
5+
}
36
]

0 commit comments

Comments
 (0)